elixir-mint / mint / f707415a1199ec76812b001925841af938bb7478-PR-522

91%

main: 91%

Build Type

Pull #522

github

Committed by ericmj

Commit Message

Treat a 204 response to CONNECT as an established tunnel

The check for 204 and 304 responses, which must not have content, came
before the check for 2xx responses to CONNECT. A CONNECT request
answered with 204 was treated as a response without content, so the
first DATA frame on the tunnel failed the request with a protocol error.

RFC 9110 9.3.6 and RFC 9113 8.5 make any 2xx response to CONNECT
establish a tunnel, so the CONNECT case is checked first and DATA
frames after a 204 are delivered as tunnel data.

Pull Request Pull Request #522: Fix HTTP/2 header block bound, push validation and CONNECT 204

Coverage Stats

52 of 54 new or added lines in 1 file covered. (96.3%)

2 existing lines in 1 file now uncovered.

1827 of 2012 relevant lines covered (90.81%)

717.04 hits per line