elixir-mint / mint / 6184a568114607dd3d727a517affb15997a1bbad-PR-507

89%

main: 91%

Build Type

Pull #507

github

Committed by ericmj

Commit Message

Apply acknowledged HTTP/2 client settings for the header table and window sizes

put_settings/2 accepted :header_table_size but the handler for the
server's SETTINGS ACK didn't know the setting and raised a RuntimeError
out of stream/2. The setting is now recorded and the HPACK decode table
is resized to it, so the server can signal dynamic table sizes up to the
new maximum.

Shrinking :initial_window_size adjusted each stream's receive window
size but not its remaining credit. The server applies the difference to
its view of the window as well (RFC 9113 6.9.2), so the next refill
computed an increment of zero or a negative number and sent it in a
WINDOW_UPDATE frame, which the server must treat as a stream error
(RFC 9113 6.9). The remaining credit now follows the size change and a
refill is only sent when the increment is positive.

Pull Request Pull Request #507: Apply acknowledged HTTP/2 client settings for the header table and window sizes

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

39 existing lines in 1 file now uncovered.

1520 of 1718 relevant lines covered (88.47%)

541.61 hits per line