dblock / distance_of_time_in_words

100%

master: 99%

LAST BUILD ON BRANCH restore-same-clock-coverage

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• add-coveralls-coverage
• add-dublin-cross-zone-example
• add-luxon-cross-zone-example
• add-norfolk-cross-zone-example
• fix-165-offset-delta
• fix-timezone-deprecation-warning
• issue-160
• issue-162
• master
• restore-same-clock-coverage

Build # 34405895425

Build Type

push

github

Committed by dblock

Commit Message

Restore full test coverage for same_clock?'s TimeZone-object branch

#165 moved the offset_delta/same_clock? call out of TimeHash#initialize
(where it ran unconditionally for every from/to based call) into
build_years_months_weeks_days (where it only runs for distances that
get split into calendar fields, years/months/weeks/days). The only
existing spec exercising same_clock?'s "zone is a TimeZone object, not
a String" comparison (#162) uses a 1 hour distance, too small to reach
build_years_months_weeks_days at all, so that branch silently stopped
being covered by any spec (100% -> 99.65% overall).

Adds a second #162-shaped example, spanning over a year so it's split
into calendar fields, confirming Tokyo/LA (unrelated zones, not the
same clock) are still correctly treated as different clocks at that
distance too.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

283 of 283 relevant lines covered (100.0%)

630.12 hits per line