dblock / distance_of_time_in_words / 34404801208

100%

master: 99%

push

github

Add Pacific/Norfolk historical offset regression example, fix #170

Adds a regression example (from https://github.com/dblock/tz_test)
demonstrating that Pacific/Norfolk's 2015 historical UTC offset change
(#153) folds correctly into the calendar distance rather than leaking
as a spurious 30 minutes.

Also fixes #170, discovered while verifying this example across the
full Rails version matrix: distance_of_time_in_words unconditionally
called #to_time on any ActiveSupport::TimeWithZone argument, which on
Rails < 8.0 (before to_time_preserves_timezone defaulted to :zone)
discards the real timezone and returns a plain Time in the process's
local zone instead. This meant same_clock? (added for #162/#165) could
never recognize two TimeWithZone values as the same clock on Rails <
8.0, even when they obviously were - not because the underlying bug is
inherent to older Rails, but because of an unforced conversion dotiw
performed on an argument that didn't need it. TimeWithZone already
supports every operation TimeHash needs without ever being converted to
a plain Time, so #coerce_to_time now only converts arguments that
aren't already a Time or TimeWithZone (e.g. Date/DateTime). This makes
the Norfolk example (and the existing #165 Dublin example) pass on
every supported Rails version, not just Rails >= 8.0.

Verified locally across the full test suite and the Rails 7.0-8.1
gemfiles, 0 failures, no skips required.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

282 of 283 relevant lines covered (99.65%)

627.02 hits per line