dblock / distance_of_time_in_words / 34403430329

99%

master: 99%

Build Type

push

github

Committed by dblock

Commit Message

Fix #165: only fold UTC offset changes into the sub-day leftover, not the top-level distance

offset_delta previously applied its correction to the top-level distance
used to pick which build_* branch to use, which could overcorrect past
zero when the real elapsed time was smaller than the DST/tzdata offset
change itself (e.g. Europe/Dublin's 1 hour fall-back masking a genuine
1 minute difference, reported as "less than 1 second"). The correction
is now applied only once the distance has already been split into
calendar fields (years/months/weeks/days), to the sub-day leftover
only, guarded against being re-applied when both build_years and
build_months invoke the same calculation (accumulate_on: :years).

Also removes the Rails >= 8.0 skip on the regression spec: with the
fix in place, it passes on every supported Rails version, not just
those where #to_time preserves the TimeZone object.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

278 of 280 relevant lines covered (99.29%)

605.43 hits per line