RobotWebTools / rclnodejs
91%

DEFAULT BRANCH: develop
Repo Added
Files 67
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH develop
branch: SELECT
CHANGE BRANCH
x

coverage: 90.812% (+0.007%) from 90.805%
34312501840

push

github

web-flow 
Write generated/generator.json only after message generation completes (#1595)

## Problem

If message generation does not run to completion, `rclnodejs.init()` keeps treating the partial `generated/` tree as complete. Every interface that was never written then fails with `MESSAGE_NOT_FOUND` on every start, and the only way out is to delete `generated/` by hand. The two realistic ways to get there are the generating process being killed part-way (SIGKILL/OOM during `npm install`, Ctrl-C on `generate-ros-messages`, CI/container teardown) and any single package failing to generate (EACCES, ENOSPC, a malformed interface). In the second case `npm install` also exits 0, because the `postinstall` script only logs the error, so the partial tree is left behind silently.

## Root cause

- `rosidl_gen/index.cjs:87-90` copies `generator.json` (the version marker `init()` uses to decide whether regeneration is needed) into `generated/` before the per-prefix `generateInPath()` loop at `rosidl_gen/index.cjs:103-105` has generated a single interface file.
- `index.js:422-424` (`getCurrentGeneratorVersion()` / `forced`) only regenerates when that file is absent or carries an older version, so a partial tree with a current-version marker is never regenerated.
- `scripts/generate_messages.cjs:36-38` catches the error, prints `Caught error: ...` and returns normally, so the process exits 0.

## Fix

- `rosidl_gen/index.cjs`: write `generated/generator.json` last, after the `generateInPath()` loop. `generated/` is now created with `fse.mkdirs()` up front (the `generator.json` copy used to create it implicitly). A tree left behind by an interrupted or failed run has no marker, `getCurrentGeneratorVersion()` returns `null`, and `init()` regenerates it on the next start with no other change.
- `scripts/generate_messages.cjs`: `process.exit(1)` in the catch handler so `npm install` and `npx generate-ros-messages` report the failure instead of succeeding with a partial tree.... (continued)

2252 of 2651 branches covered (84.95%)

Branch coverage included in aggregate %.

17811 of 19442 relevant lines covered (91.61%)

219.42 hits per line

Relevant lines Covered
19442 RELEVANT LINES 17811 COVERED LINES
219.42 HITS PER LINE
Source Files on develop

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34312501840 develop Write generated/generator.json only after message generation completes (#1595) ## Problem If message generation does not run to completion, `rclnodejs.init()` keeps treating the partial `generated/` tree as complete. Every interface that was nev... push web-flow github
90.81
34281545305 fix/write-generator-marker-last Merge f30198c31 into 4bf514e59 Pull #1595 web-flow github
90.81
34197822485 fix-1579-websocket Merge 994b0e68c into 4bf514e59 Pull #1593 web-flow github
90.9
34181735844 fix-1579-websocket Merge 4da9e3e9d into 4bf514e59 Pull #1593 web-flow github
90.9
34112774887 fix-1579-websocket Merge 5a8116bb4 into 4bf514e59 Pull #1593 web-flow github
90.9
34111475613 fix-1579-websocket Merge 96beecd00 into 4bf514e59 Pull #1593 web-flow github
90.9
34108711834 fix-1579-websocket Merge fea840a9a into 4bf514e59 Pull #1593 web-flow github
90.9
34100118679 develop [Web runtime] Add core action capability dispatch (1/3) (#1586) - Add action capabilities to the registry, CLI configuration, and runtime types - Support goal submission, feedback, results, and per-goal cancellation - Report unavailable servers, ... push web-flow github
90.8
34096277839 fix-1579-core Merge c762b7f13 into a46fdee93 Pull #1586 web-flow github
90.81
34091136980 fix-1579-core Merge 6d71ced86 into a46fdee93 Pull #1586 web-flow github
90.81
See All Builds (2115)