RobotWebTools / rclnodejs / 23176049662

86%

push

github

Re-enable tests on Jazzy for Windows (#1435)

Replaces the legacy `setup-ros`-based Windows CI with a unified pixi-based workflow covering Jazzy, Kilted, and Rolling. Removes Humble from Windows CI (EOL distro, `setup-ros` unmaintained). Tests run only on Jazzy; Kilted and Rolling are build-only. Fixes an intermittent Electron test hang on Linux CI caused by async `app.quit()` racing with `process.exit()`. Adds targeted Windows-only test skips for six test cases with platform-specific portability issues.

**CI workflow changes:**

- `.github/workflows/windows-build-and-test.yml` — Replaced `setup-ros` + `c:\dev\` install path with `prefix-dev/setup-pixi@v0.9.4` + pixi-managed `C:\pixi_ws` layout. Distro matrix changed from `[humble, jazzy, kilted, rolling]` to `[jazzy, kilted, rolling]` with per-distro release zip URLs via `include`. Tests gated by `matrix.run_tests` (true only for Jazzy). Removed stale Foxy-era comment about CycloneDDS workaround.
- `.github/workflows/windows-pr-test.yml` — Job renamed `build-and-test` → `pixi-build`.
- `.github/workflows/windows-push-test.yml` — Job renamed `build-and-test` → `pixi-build`.

**Electron test fix:**

- `test/electron/test_usability.js` — Replaced `app.quit()` + `process.exit()` with `app.exit(code)` for immediate synchronous termination, preventing orphan GPU/utility processes from keeping `xvfb-run` pipes open. Added `testDone` guard to prevent double-fire of subscription callback and timeout. Hoisted `interval` declaration above subscription creation to avoid temporal dead zone. Added `clearInterval(interval)` in the success path.

**Targeted Windows test skips:**

- `test/test-native-loader.js` — Skip `customFallbackLoader attempts to require exact match if exists` on Windows (test overrides `process.platform` to `linux` and probes Ubuntu-specific prebuild paths).
- `test/test-rate.js` — Skip `rate sleep accuracy test, 1000 hz for 3 seconds` on Windows (Windows timer resolution ~15ms cannot meet 1kH... (continued)

1403 of 1770 branches covered (79.27%)

Branch coverage included in aggregate %.

2876 of 3209 relevant lines covered (89.62%)

461.62 hits per line