6650
0%
main: 93%

Ran 04 Sep 2015 03:44PM UTC

Jobs 10

Files 385

Run time 14min

Badge

Embed ▾

pending completion

Build # 6650

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Re-work REPL mutual exclusion.

The old method required modifying Target which was untenable for
plugins.  A new approach is taken by introducing a MutexTaskMixin that
supports forming groups of tasks that all provide the same mutually
exclusive service.  The functionality is the same as that provided by
the previous pairing of `Target.lang_discriminator` and
`Task.require_homogeneous_targets`, but with a more flexible version of
`Target.lang_discriminator` that allows any installed tasks with a
shared MutexTaskMixin to form a mutual exclusion group in an
uncoordinated manner (save from mixing in the shared base mutex mixin).

The `ReplTaskMixin` serves as the realization of this concept and both
`PythonRepl` and `ScalaRepl` tasks and tests are retrofitted to use it.

This paves the way for the node contrib plugin to provide its own
`NodeRepl` in a follow-up RB.

Testing Done:
I manually verified the fail-fast behavior on conflicting REPLs works
just like it did before and also verified python and scala REPLs worked
on various targets.  New unit tests seal this behavior in as well in
MutexTaskMixin as well as an old test method in PythonReplTest.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/78769440

Bugs closed: 2110, 2132

Reviewed at https://rbcommons.com/s/twitter/r/2765/

Run Details

17278 of 22908 relevant lines covered (75.42%)

1.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6650.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	04 Sep 2015 03:44PM UTC		Travis Job 6650.1
2	6650.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	04 Sep 2015 03:45PM UTC	71.15	Travis Job 6650.2
3	6650.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	04 Sep 2015 03:46PM UTC	70.98	Travis Job 6650.3
4	6650.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	04 Sep 2015 03:44PM UTC		Travis Job 6650.4
5	6650.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	04 Sep 2015 03:52PM UTC		Travis Job 6650.5
6	6650.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	04 Sep 2015 03:55PM UTC		Travis Job 6650.6
7	6650.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	04 Sep 2015 03:53PM UTC		Travis Job 6650.7
8	6650.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	04 Sep 2015 03:55PM UTC		Travis Job 6650.8
9	6650.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	04 Sep 2015 03:55PM UTC		Travis Job 6650.9
10	6650.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	04 Sep 2015 03:59PM UTC		Travis Job 6650.10

Source Files on build 6650

Detailed source file information is not available for this build.

pantsbuild / pants / 6650
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6650

pantsbuild / pants / 6650 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6650

pantsbuild / pants / 6650
0%
main: 93%

README BADGES
x