6653
0%
main: 93%

Ran 04 Sep 2015 04:33PM UTC

Jobs 10

Files 385

Run time 10min

Badge

Embed ▾

pending completion

Build # 6653

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Add support for `repl.node`.

This builds off of the new ReplTaskMixin and NodeRepl itself is a small
task.

To support NodeRepl well, a few adjustments are made:

1. MutexTaskMixin is given better failure output when identifying
   mutually incompatible targets.
2. NpmResolve is updated to support resolving remote modules directly.
3. The NodePaths product if broken out of NpmResolve to present a more
   neutral data type and not explicitly couple NpmResolve to NodeRepl.

An example node 3rdparty dep is added to support some integration tests
and the existing NodeTask and NpmResolve tests are expanded to cover the
new functionality added to the respective classes.

Testing Done:
Played with the repl: piping scripts to it, passing scripts via
`-- --eval ...` and just dropping into the repl and using it - all
using the `contrib/node/examples/3rdparty/node:typ` target.

Added integration tests cover this.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/78782743

Bugs closed: 2110, 2134

Reviewed at https://rbcommons.com/s/twitter/r/2766/

Run Details

17266 of 22910 relevant lines covered (75.36%)

1.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6653.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	04 Sep 2015 04:33PM UTC		Travis Job 6653.1
2	6653.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	04 Sep 2015 04:33PM UTC	70.92	Travis Job 6653.2
3	6653.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	04 Sep 2015 04:33PM UTC	70.95	Travis Job 6653.3
4	6653.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	04 Sep 2015 04:34PM UTC		Travis Job 6653.4
5	6653.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	04 Sep 2015 04:35PM UTC		Travis Job 6653.5
6	6653.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	04 Sep 2015 04:40PM UTC		Travis Job 6653.6
7	6653.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	04 Sep 2015 04:40PM UTC		Travis Job 6653.7
8	6653.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	04 Sep 2015 04:43PM UTC		Travis Job 6653.8
9	6653.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	04 Sep 2015 04:39PM UTC		Travis Job 6653.9
10	6653.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	04 Sep 2015 04:39PM UTC		Travis Job 6653.10

Source Files on build 6653

Detailed source file information is not available for this build.

pantsbuild / pants / 6653
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6653

pantsbuild / pants / 6653 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6653

pantsbuild / pants / 6653
0%
main: 93%

README BADGES
x