pantsbuild / pants
93%

DEFAULT BRANCH: main
Repo Added
Files 1782
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 92.893% (-0.002%) from 92.895%
33265103538

push

github

web-flow 
Infer dependencies across local `replace` directives in the Go backend (#23431)

## Problem

A `go.mod` can `replace` a required module with a path to a local
directory holding another first-party module:

```
// context/app/go.mod
require example.com/shared v0.0.0
replace example.com/shared => ../shared
```

Module analysis skips these, since they are not third-party packages,
and nothing folded the replaced module's packages into the referencing
module's import-path map. An import of `example.com/shared/pkg/field`
from `context/app` was therefore never resolved by dependency inference,
and every cross-module dependency had to be listed by hand in BUILD
metadata. In a repo whose first-party graph is wired together with
directory replaces, that is most of the dependency edges.

## Fix

`determine_go_mod_info` records each `replace` whose target is a local
directory, mapping the replaced module path to that directory relative
to the build root. It reads this from the `go mod` JSON metadata Pants
already fetches, so no extra process runs.

`map_import_paths_to_packages` merges the replaced module's own
packages, import paths at or under its module path, into the referencing
module's mapping. Its third-party dependencies are deliberately not
merged: the referencing module resolves those through its own `go.mod`,
and merging them would make shared third-party imports ambiguous and
silently suppress inference. Replace directives are not transitive in
Go, so the merge is one level deep. A module without a directory replace
takes the unchanged path.

Closes #22097, and the matching TODO in `third_party_pkg.py`.

## Verification

Two new tests in `target_type_rules_test.py` cover inference across a
locally-replaced sibling module, and a third-party import shared by both
modules staying unambiguous. The `util_rules/::` and `target_type_rules`
suites pass. Validated end to end on a real 24-module monorepo: every
cross-module import that previously needed an exp... (continued)

49 of 54 new or added lines in 3 files covered. (90.74%)

95539 of 102848 relevant lines covered (92.89%)

3.66 hits per line

Relevant lines Covered
102848 RELEVANT LINES 95539 COVERED LINES
3.66 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
33265103538 main Infer dependencies across local `replace` directives in the Go backend (#23431) ## Problem A `go.mod` can `replace` a required module with a path to a local directory holding another first-party module: ``` // context/app/go.mod require example... push web-flow github
92.89
33198315340 2.33.x Restart pantsd when `[GLOBAL].plugins` changes (Cherry-pick of #23650) (#23656) Fixes #23649. `[GLOBAL].plugins` was not marked `daemon=True`, so changing it only reinitialized the scheduler. `pantsd` resolves plugins into its own process, and `... push web-flow github
92.96
33149007614 sandboxer_on_by_default Merge f243c51ba into 8eb7d2fbb Pull #23660 web-flow github
63.75
33124995371 fix-issue-23628 Merge 1b816877f into 8eb7d2fbb Pull #23659 web-flow github
52.69
33104020829 2.33.x Prepare 2.33.1 (#23638) push web-flow github
92.96
33090306848 main Condition chmod on file not already being executable. (#23655) This allows Pants to run out of a read-only area for a multi-user installation. push web-flow github
92.89
33087349365 chmod_fix Merge abf79b76c into 37996f292 Pull #23655 web-flow github
92.89
33038168280 cherry-pick-23650-to-2.33.x Merge 05f43e032 into b9c557f80 Pull #23656 web-flow github
92.96
33038133062 main Restart pantsd when `[GLOBAL].plugins` changes (#23650) Fixes #23649. `[GLOBAL].plugins` was not marked `daemon=True`, so changing it only reinitialized the scheduler. `pantsd` resolves plugins into its own process, and `PluginResolver.resolve` ... push web-flow github
92.89
33009839605 chmod_fix Merge e4bcc81be into 5ce320a14 Pull #23655 web-flow github
92.89
See All Builds (13258)