pantsbuild / pants / 6650 / 2
0%
main: 93%

LAST BUILD BRANCH: pex-2.91.4
DEFAULT BRANCH: main
Ran
Files 385
Run time 17s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.145% (+1.0%) from 70.143%
CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

push

travis-ci

jsirois 
Re-work REPL mutual exclusion.

The old method required modifying Target which was untenable for
plugins.  A new approach is taken by introducing a MutexTaskMixin that
supports forming groups of tasks that all provide the same mutually
exclusive service.  The functionality is the same as that provided by
the previous pairing of `Target.lang_discriminator` and
`Task.require_homogeneous_targets`, but with a more flexible version of
`Target.lang_discriminator` that allows any installed tasks with a
shared MutexTaskMixin to form a mutual exclusion group in an
uncoordinated manner (save from mixing in the shared base mutex mixin).

The `ReplTaskMixin` serves as the realization of this concept and both
`PythonRepl` and `ScalaRepl` tasks and tests are retrofitted to use it.

This paves the way for the node contrib plugin to provide its own
`NodeRepl` in a follow-up RB.

Testing Done:
I manually verified the fail-fast behavior on conflicting REPLs works
just like it did before and also verified python and scala REPLs worked
on various targets.  New unit tests seal this behavior in as well in
MutexTaskMixin as well as an old test method in PythonReplTest.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/78769440

Bugs closed: 2110, 2132

Reviewed at https://rbcommons.com/s/twitter/r/2765/

16298 of 22908 relevant lines covered (71.15%)

0.71 hits per line

Source Files on job 6650.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")