dgraph-io / badger / 2648

61%

main: 61%

push

travis-ci

Use standard proto functions for Marshal/Unmarshal and Size (#994)

Some of the code interacting with protobufs was calling functions
emitted by the proto compiler directly on the protobuf structs;
`proto_obj.Marshal`, `proto_obj.Unmarshal`, `proto_obj.Size`.

These functions are no longer emitted by the upstream protobuf
compiler, only by gogo/protobuf.
Users who don't use the pregenerated `pb.pb.go`, but instead
recompile the proto files using the upstream compiler will encounter
compilations failures.  (I hit this because that's the default mode
for importing go projects using bazel and gazelle).

These commits change any code that was using these functions to use
the standard proto library functions: `proto.Marshal`,
`proto.Unmarshal`, and `proto.Size`.

These changes shouldn't cause any performance effects --- the
implementations of each of these functions call out, directly or
indirectly, to the directly-attached functions, if they exist.

13 of 13 new or added lines in 5 files covered. (100.0%)

5854 of 7415 relevant lines covered (78.95%)

240751.14 hits per line