1646
61%
main: 61%

Ran 04 Oct 2018 02:04AM CUT

Jobs 1

Files 0

Run time 2s

Badge

Embed ▾

Committed 04 Oct 2018 01:58AM CUT coverage: 80.379% (-0.09%) from 80.469%

Build # 1646

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix a rare edge case for value log truncate (#602)

In a specific scenario, where a FS truncates the value log entries perfectly so that a txn's FIN entry is lost, while the rest of the transaction is not; AND this is the first transaction in the system; Badger can skip truncating this transaction on the first Replay (run when Badger is Open). But, will truncate after it has a few valid transactions. The reason is that when there's only one invalid txn, the valid offset of file becomes zero. It is hard to differentiate between a valid offset of zero, v/s an uninitialized offset.

To fix this, we use the file size as a guide. If the file size is greater than the valid offset, we would truncate the file. This interferes with value log GC (and how we grow a value log file to double it's size due to how Windows treats mmapped files). So, we move the truncate logic to within replay function, and out of iterate, so it does not interfere with the functionality of value log GC.

Also, move memory expensive tests to manual mode, and the tests write to disk instead of tmpfs.

Fixes #592 .

Run Details

4502 of 5601 relevant lines covered (80.38%)

203179.46 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1646.1	04 Oct 2018 02:04AM CUT	0	80.38	Travis Job 1646.1

dgraph-io / badger / 1646
61%
main: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1646

dgraph-io / badger / 1646 61% main: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1646

dgraph-io / badger / 1646
61%
main: 61%

README BADGES
x