dgraph-io / badger / 2797

61%

main: 61%

push

travis-ci

Fix windows build for badger (#1038)

This commit fixes windows build issues. There were 4 issues

1. Trying to truncate a mmapped file.
    On linux, we can truncate a mmapped file but on windows this
    operation is invalid. We should unmap the file before truncating it.
2. Removing a file that has open file descriptor.
    On windows we cannot delete a file if it has an open file descriptor.
    The following functions would increment the ref for a table but never
    decrease it.
     - getTableInfo function in levels.go
    	The getTableInfo function would create an iterator but never
	close it and because of this we would have issues trying to
	delete the file.
     - CreateTable function in stream writer
	The createTable function calls OpenTable which sets the ref of a
	table to 1 but we would never decrement this ref.
3. AppVeyor file checksum mismatch error (iterator errors)
    These errors were caused because we were trying to create a file with
    a random name but on appVeyor the `rand.Int63()` would return the same
    value for multiple calls. The problem was that `rand.Seed` was called
    with a `time.Now()` timestamp which wasn't always unique on AppVeyor. 
4. AppVeyor out of disk space error.
    In some of the tests we weren't closing the DB and trying to remove
    the directory. This meant the directory would never get deleted and
    thus AppVeyor would run out of disk space.

With this commit, the AppVeyor build should succeed.

20 of 20 new or added lines in 5 files covered. (100.0%)

17983 of 22984 relevant lines covered (78.24%)

154790.04 hits per line