2
61%
main: 61%

Ran 22 Aug 2019 07:55AM UTC

Files 36

Run time 3s

Badge

Embed ▾

Committed 22 Aug 2019 07:47AM UTC coverage: 78.881% (+0.2%) from 78.705%

Job # 2648.2

Build Type

push

travis-ci

Committed by

jarifibrahim

Commit Message

Use standard proto functions for Marshal/Unmarshal and Size (#994)

Some of the code interacting with protobufs was calling functions
emitted by the proto compiler directly on the protobuf structs;
`proto_obj.Marshal`, `proto_obj.Unmarshal`, `proto_obj.Size`.

These functions are no longer emitted by the upstream protobuf
compiler, only by gogo/protobuf.
Users who don't use the pregenerated `pb.pb.go`, but instead
recompile the proto files using the upstream compiler will encounter
compilations failures.  (I hit this because that's the default mode
for importing go projects using bazel and gazelle).

These commits change any code that was using these functions to use
the standard proto library functions: `proto.Marshal`,
`proto.Unmarshal`, and `proto.Size`.

These changes shouldn't cause any performance effects --- the
implementations of each of these functions call out, directly or
indirectly, to the directly-attached functions, if they exist.

Coverage Stats

5849 of 7415 relevant lines covered (78.88%)

78821.02 hits per line

dgraph-io / badger / 2648 / 2
61%
main: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2648.2

dgraph-io / badger / 2648 / 2 61% main: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2648.2

dgraph-io / badger / 2648 / 2
61%
main: 61%

README BADGES
x