KarpelesLab / goro

12%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: wrap trait-aliased/from-trait methods in MethodCallable for ByExprs dispatch

CallInstanceMethodByExprs was passing method.Method directly to ctx.Call
when no Attributes were present, which lost the trait-alias name in
stack traces and used the trait body's declaring class instead of the
class that did 'use T'. The AST runner (compile-object.go ~1245) wraps
in MethodCallable when:
  - method.FromTrait != nil  (the method came from a trait body)
  - method.Method.Name() != called-name  (the method is a trait alias,
    e.g. 'T::__get as __t_get' — Name() returns '__get', called as
    '__t_get')

Mirror the same logic. bug69180-backtrace.phpt was regressing because
the call to $this->__t_get($name) from Model::__get was reporting
'T::__get' in debug_backtrace() instead of 'Model::__t_get'.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

8 of 17 new or added lines in 1 file covered. (47.06%)

1 existing line in 1 file now uncovered.

14748 of 118202 relevant lines covered (12.48%)

2578.84 hits per line