KarpelesLab / goro / 26434484640

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

compiler: relax IsSlotSafe gates for natively-emitted writes

Object-prop / static-prop / dyn-name compound assigns and inc/dec,
plus $local[k] OP=/++, all now emit natively (no AST.Run delegation).
The dispatch handlers don't touch caller locals, so bodies containing
these writes can remain slot-only — the slot cache stays authoritative
without OffsetSet/OffsetCheck round-trips through the hashtable.

Specifically:
  - runObjectVar: drop isCompound|isIncDec gate (was forcing slot-unsafe
    for $obj->n += v / $obj->n++); the static-name and dollar-prefix
    dyn-name shapes are both natively lowered.
  - runClassStaticVarRef: drop isCompound|isIncDec gate; plain '=',
    compound, and inc/dec all emit natively now.
  - runClassStaticDynVarRef: previously unconditional return false; now
    a no-op fall-through since the dyn-name write/compound/incdec all
    emit natively too.
  - runArrayAccess: drop isCompound|isIncDec gate when the container
    is a simple variable (matches the OP_ARRAY_COMPOUND_ASSIGN_LOCAL /
    OP_ARRAY_INC_DEC_LOCAL fast paths from the previous commit). Nested
    containers ($obj->arr[i] += v, $a[i][j]++, …) still slot-unsafe.

Smoke-tested: loop_obj_compound, loop_static_compound, loop_compound
all byte-identical to AST baseline; expr-context ($z = ($arr[0] *= 3)
+ $arr[1]) byte-identical.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

19 of 20 new or added lines in 1 file covered. (95.0%)

4 existing lines in 1 file now uncovered.

14964 of 119430 relevant lines covered (12.53%)

2559.89 hits per line