KarpelesLab / goro / 26394336499

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower $b = &$a ref-assign for simple-local LHS natively

Adds OP_STORE_LOCAL_REF, writing a ref-typed ZVal into a local slot
without the COW-Dup that OP_STORE_LOCAL applies to ZtArray values
(frame.go:160-166 follows ref→Nude+Dup, which detaches the ref).

Emit path: $b = &$a where LHS is a simple variable
  - emit RHS (\&$a → OP_CREATE_REF produces ref ZVal)
  - OP_STORE_LOCAL_REF idx=$b localIdx

Handler:
  - pop value
  - if IsRef, call RefInner() to track alias count
  - write directly into the slot (no Dup, no Nude)
  - mirror through ctx.OffsetSet for non-slot-only frames
  - keep-value flag for expr context ($x = ($b = &$a))

Complex LHS (object prop, array elem, static prop) still routes
through AST — those write paths each carry their own ref-installation
semantics that this stage-1 lowering doesn't replicate.

VM output byte-identical to AST baseline across the 7-test smoke
suite (scalar/array/string ref-share, function by-ref pass-through,
unset-detach, ref-chain, and the expr-context $x = ($b = &$a) edge).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

28 of 38 new or added lines in 2 files covered. (73.68%)

12 existing lines in 2 files now uncovered.

14964 of 119318 relevant lines covered (12.54%)

2562.28 hits per line