KarpelesLab / goro / 26391790448

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower isset/empty on static prop + fix bug44660 inc/dec error verb

Two related changes:

1) Lower isset(Foo::\$bar) / empty(Foo::\$bar) natively.

   New helpers in compile-isset.go:
     EvalIssetStaticProp — mirrors checkExistence's *runClassStaticVarRef
       branch (class lookup, IsStaticPropAccessible, FindStaticProp,
       non-null check). Errors are swallowed.
     EvalEmptyStaticProp — wraps EvalClassStaticVarRead; any error or
       missing prop is treated as empty (matches checkEmpty's default).

   New opcodes:
     OP_ISSET_STATIC_PROP — A = name-const-idx. Pops class-source,
       pushes bool.
     OP_EMPTY_STATIC_PROP — same shape, calls EvalEmptyStaticProp.

   IsIssetSupportedArg now accepts *runClassStaticVarRef so
   IssetEmptyAllSupported routes the whole isset(a, b, c) chain
   natively when all args are static-prop reads.

2) Fix bug44660 regression introduced by OP_INC_DEC_OBJ_PROP.

   The native inc/dec handler bypassed runObjectVar.Run's
   incDecCtx branch, so \$a->p++ on a non-object receiver threw
   "Attempt to assign property" instead of the expected
   "Attempt to increment/decrement property". Mirror the
   compile-object.go:1316 branch directly in the opcode handler
   by checking the receiver before objectGet.

   This brings the failing-test set back from 81 to 80 on the
   commit that introduced the inc/dec opcode (fc96192d) plus
   the new isset/empty static-prop coverage.

Verified locally:
  - isset/empty on declared / null / falsy / undeclared / private
    static props
  - isset(Foo::\$a, Foo::\$nul) chain
  - \$a->p++ on bool/int/array/null receiver -> correct
    "Attempt to increment/decrement" Error
  - existing prop / static-prop / LSB inc/dec smoke tests
    still pass

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

8 of 96 new or added lines in 4 files covered. (8.33%)

2 existing lines in 1 file now uncovered.

14919 of 118849 relevant lines covered (12.55%)

2572.35 hits per line