KarpelesLab / goro / 26391453745

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower Foo::\$bar OP= rhs to OP_STATIC_PROP_COMPOUND_ASSIGN

Mirrors the OP_OBJECT_COMPOUND_ASSIGN landed in the prior commit.

Encoding:
  A = const-pool name index (ZString varName, w/o leading $)
  B = tokenizer ItemType (op token)
  C bit 0 = keep-value-on-stack (expr vs stmt context)

Stack: pops rhs, pops class-source. Handler:
  cur, _ := EvalClassStaticVarRead(ctx, class-source, name, loc)
  cur := cur.Dup()
  res := compoundOp(op)(cur, rhs)
  AssignClassStaticProp(ctx, class-source, name, res)
  if C&1 { push(res) }

Both helpers already exist and carry LSB-aware class resolution,
read-side and asymmetric write-side visibility checks, and typed-prop
coercion. The native path inherits those unchanged.

Verified locally:
  Counter::\$n += 5    -> 15
  Counter::\$n *= 2    -> 26
  Counter::\$s .= ' world' -> 'hi world'
  Expr ctx: \$x = (Counter::\$n += 100) -> both 126
  LSB:  Parent1::bump() bumps Parent1::\$cnt,
        Child1::bump()  bumps Child1::\$cnt
        (static::\$cnt picks up the called class)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

34 of 56 new or added lines in 2 files covered. (60.71%)

1 existing line in 1 file now uncovered.

14864 of 118620 relevant lines covered (12.53%)

2577.32 hits per line