databendlabs / openraft

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

test: storage suite must use C::NodeId Display, not u64, for progress id

In `Suite::get_initial_state`, the expected `RaftState` was built with
`NODE_ID.to_string()` where `NODE_ID: u64 = 0`.  The production path in
`StorageHelper::with_id` calls `id.to_string()` on a `C::NodeId`, which
goes through the user's `Display` impl.  When that impl produces anything
other than a bare integer (e.g. `"Node[0]"`), the `assert_eq!(want,
initial)` assertion fails because `IOProgress` derives `PartialEq` and
the `id: String` label participates in equality.

The fix is one extra line: convert `NODE_ID` to `C::NodeId` first so that
both sides use the same `Display`.

A new workspace crate `openraft-memstore-custom-node-id` is added as a
regression guard.  It is a minimal storage implementation (no blocking
hooks, no application data, no feature flags) whose only distinguishing
feature is a `NodeId` whose `Display` yields `"Node[N]"`.  Running its
test suite against an unfixed `suite.rs` reproduces the failure; after the
fix all tests pass.

- Fix: #1659

Run Details

158 of 165 new or added lines in 3 files covered. (95.76%)

8 existing lines in 3 files now uncovered.

15838 of 18040 relevant lines covered (87.79%)

148570.56 hits per line