databendlabs / openraft / 22842783777

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: in 0.10.0: convert `RaftLeaderId` generic params `<Term, NID>` to associated types

Since Term and NID are always determined by the implementing type, they
belong as associated types rather than generic parameters. This simplifies
trait bounds, removes PhantomData from LeaderIdCompare, and eliminates
redundant generic params from RaftLeaderIdExt.

Upgrade tip:

Update `RaftLeaderId` implementations to use associated types instead of
generic parameters:

Before:
    impl<Term, NID> RaftLeaderId<Term, NID> for MyLeaderId<Term, NID> {
        type Committed = MyCommitted;
        fn new(term: Term, node_id: NID) -> Self { ... }
    }

After:
    impl<Term, NID> RaftLeaderId for MyLeaderId<Term, NID> {
        type Term = Term;
        type NodeId = NID;
        type Committed = MyCommitted;
        fn new(term: Self::Term, node_id: Self::NodeId) -> Self { ... }
    }

`LeaderIdCompare` no longer has type parameters:
- `LeaderIdCompare::<Term, NID>::std(a, b)` → `LeaderIdCompare::std(a, b)`

`RaftTypeConfig::LeaderId` bound updated:
- `RaftLeaderId<Self::Term, Self::NodeId>` → `RaftLeaderId<Term = Self::Term, NodeId = Self::NodeId>`

Run Details

18 of 18 new or added lines in 3 files covered. (100.0%)

4 existing lines in 2 files now uncovered.

15847 of 18086 relevant lines covered (87.62%)

147652.41 hits per line