databendlabs / openraft / 22909938482

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: in 0.10.0: decouple `MembershipState`, `ChangeMembershipError`, and `InProgress` from `RaftTypeConfig`

Replace the monolithic `C: RaftTypeConfig` parameter with only the
specific types each definition actually needs, continuing the
type-decoupling effort.

`MembershipState<C>` becomes `MembershipState<CLID, NID, N>` since it
only wraps `EffectiveMembership` (already decoupled) and `LogId`.
`ChangeMembershipError<C>` becomes `ChangeMembershipError<CLID, NID>`
since it only contains `InProgress<CLID>` and `LearnerNotFound<NID>`.
`InProgress<C>` becomes `InProgress<CLID>` since it only stores
`LogId<CLID>` fields.

`ChangeHandler` (pub(crate)) is updated accordingly.

Changes:
- Add `MembershipStateOf<C>`, `ChangeMembershipErrorOf<C>`, `InProgressOf<C>` type aliases
- Implement `Default` manually for `MembershipState` to avoid over-constraining bounds

Upgrade tip:

    Replace `MembershipState<C>` with `MembershipState<CLID, NID, N>`,
    or use the type alias `MembershipStateOf<C>`:

    // Before
    let ms: MembershipState<MyConfig> = ...;

    // After
    use openraft::alias::MembershipStateOf;
    let ms: MembershipStateOf<MyConfig> = ...;

    Replace `ChangeMembershipError<C>` with `ChangeMembershipError<CLID, NID>`:

    // Before
    fn handle(e: ChangeMembershipError<MyConfig>) { ... }

    // After
    fn handle(e: ChangeMembershipError<MyCommittedLeaderId, MyNodeId>) { ... }

    Replace `InProgress<C>` with `InProgress<CLID>`:

    // Before
    fn check(e: InProgress<MyConfig>) { ... }

    // After
    fn check(e: InProgress<MyCommittedLeaderId>) { ... }

Run Details

39 of 39 new or added lines in 7 files covered. (100.0%)

6 existing lines in 3 files now uncovered.

15924 of 18188 relevant lines covered (87.55%)

145617.03 hits per line