databendlabs / openraft

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: in 0.10.0: convert `RaftVote` from `RaftVote<C>` to associated type with `type LeaderId`

Decouple `RaftVote` from `RaftTypeConfig` by replacing the `C: RaftTypeConfig`
type parameter with an associated type `LeaderId: RaftLeaderId`. This mirrors
the earlier `RaftLeaderId` refactoring and breaks the circular type dependency
where `RaftTypeConfig` referenced `RaftVote<Self>`.

Internal vote types (`CommittedVote`, `UncommittedVote`, `VoteStatus`, `RefVote`)
are now parameterized by `LID: RaftLeaderId` instead of `C: RaftTypeConfig`,
and `into_vote()` becomes generic over `V: RaftVote<LeaderId = LID>` so callers
choose the concrete vote type without knowing `C`.

Type aliases `CommittedVoteOf<C>`, `UncommittedVoteOf<C>`, `LeaderTerm<LID>`,
`LeaderNodeId<LID>`, and `LeaderCommitted<LID>` are added to keep call sites
concise.

Changes:
- `RaftVote<C>` becomes `RaftVote { type LeaderId: RaftLeaderId }`;
  bound changes from `Vote: RaftVote<Self>` to `Vote: RaftVote<LeaderId = Self::LeaderId>`
- `CommittedVote<C>` / `UncommittedVote<C>` / `VoteStatus<C>` / `RefVote<C>`
  become `<LID>` where `LID: RaftLeaderId`
- `into_vote()` on `CommittedVote` and `UncommittedVote` is now generic:
  `fn into_vote<V: RaftVote<LeaderId = LID>>(self) -> V`

Upgrade tip:

Replace `impl RaftVote<C> for MyVote` with:
    impl RaftVote for MyVote {
        type LeaderId = MyLeaderId;
        // ...
    }

Replace trait bounds `V: RaftVote<C>` with `V: RaftVote<LeaderId = C::LeaderId>`.

Run Details

129 of 146 new or added lines in 21 files covered. (88.36%)

16 existing lines in 5 files now uncovered.

15856 of 18120 relevant lines covered (87.51%)

146038.44 hits per line