databendlabs / openraft / 22899709416

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: in 0.10.0: decouple entry, membership, and log types from `RaftTypeConfig`

Replace `C: RaftTypeConfig` with the specific type parameters each type
actually needs, breaking circular type dependencies and making these
types usable without a full config.

- `LogIdList<C>`, `LeaderLogIds<C>`, `LeaderLogIdsIter<C>`
  → generic over `CLID: RaftCommittedLeaderId`.
  `LogIdList::get_key_log_ids` takes `C` as a method-level generic
  since it needs `RaftLogReader<C>`.

- `LogStateReader<C>` → `LogStateReader<CLID>`.
  `RaftState<C>` implements `LogStateReader<CommittedLeaderIdOf<C>>`.

- `Membership<C>` → `Membership<NID, N>`.
  `ChangeMembers<C>` → `ChangeMembers<NID, N>`.
  Error types `NodeNotFound`, `LearnerNotFound`, `MembershipError`
  now take `NID` instead of `C`.
  `ChangeMembershipError<C>` is unchanged (needs `InProgress<C>`).

- `RaftPayload<C>` → `RaftPayload<NID, N>`.

- `RaftEntry<C>` → `RaftEntry` with associated types
  (`CommittedLeaderId`, `D`, `NodeId`, `Node`).
  `EntryPayload<C>` → `EntryPayload<D, NID, N>`.
  `RaftTypeConfig::Entry` bound now constrains all four associated types.

Upgrade tip:

    // Before
    impl RaftEntry<MyConfig> for MyEntry { ... }
    EntryPayload<MyConfig>::Normal(data)
    Membership<MyConfig>::new(...)

    // After
    impl RaftEntry for MyEntry {
        type CommittedLeaderId = MyCommittedLeaderId;
        type D = MyAppData;
        type NodeId = MyNodeId;
        type Node = MyNode;
        ...
    }
    EntryPayload::<MyAppData, MyNodeId, MyNode>::Normal(data)
    Membership::<MyNodeId, MyNode>::new(...)

Run Details

325 of 331 new or added lines in 51 files covered. (98.19%)

10 existing lines in 2 files now uncovered.

15896 of 18151 relevant lines covered (87.58%)

146366.27 hits per line