18
99%
master: 98%

Ran 27 Oct 2020 12:05PM CUT

Files 101

Run time 7s

Badge

Embed ▾

Committed 27 Oct 2020 08:03AM CUT coverage: 34.408%. First build

Job # ruby-head

Build Type

push

travis-ci

Committed by

dnesteryuk

Commit Message

fix a performance issue with dependent params

Fixes https://github.com/ruby-grape/grape/issues/2100

The reason was in `ActiveSupport::HashWithIndifferentAccess`, it
is super expensive.

When users use a `Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder`
or `Grape::Extensions::Hashie::Mash::ParamBuilder` parameter builder
there is no change. However, users who use `Grape::Extensions::Hash::ParamBuilder`
must make sure a parameter to be dependent on must be a symbol.

    given :matrix do
      # block here
    end

Benchmark after this fix:

Warming up --------------------------------------
               Given     1.000  i/100ms
              Simple     1.000  i/100ms
Calculating -------------------------------------
               Given      0.804  (± 0.0%) i/s -     49.000  in  61.186831s
              Simple      0.855  (± 0.0%) i/s -     52.000  in  60.926097s

Comparison:
              Simple:        0.9 i/s
               Given:        0.8 i/s - 1.06x  slower

Run Details

4312 of 12532 relevant lines covered (34.41%)

0.4 hits per line

Source Files on job 4207.18 (ruby-head)

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
12.32	spec/grape/entity_spec.rb	337	203	25	178	1.0
16.06	spec/grape/endpoint/declared_spec.rb	601	355	57	298	1.0
16.09	spec/grape/validations/validators/coerce_spec.rb	1158	721	116	605	1.0
17.27	spec/shared/versioning_examples.rb	212	139	24	115	3.0
17.86	...ec/grape/api/shared_helpers_exactly_one_of_spec.rb	49	28	5	23	1.0
19.39	spec/grape/validations/validators/presence_spec.rb	302	196	38	158	1.0
22.11	spec/grape/endpoint_spec.rb	1043	606	134	472	1.0
22.16	spec/grape/validations_spec.rb	1669	1002	222	780	1.0
22.98	spec/grape/api_spec.rb	4059	2476	569	1907	1.0
23.75	spec/grape/validations/params_scope_spec.rb	1155	682	162	520	1.0

34.41
spec/

ruby-grape / grape / 4207 / 18
99%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4207.18 (ruby-head)

ruby-grape / grape / 4207 / 18 99% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4207.18 (ruby-head)

ruby-grape / grape / 4207 / 18
99%
master: 98%

README BADGES
x