4207
99%
master: 97%

Ran 27 Oct 2020 09:46AM UTC

Jobs 17

Files 101

Run time 181min

Badge

Embed ▾

pending completion

Build # 4207

Build Type

push

travis-ci

Committed by

dnesteryuk

Commit Message

fix a performance issue with dependent params

Fixes https://github.com/ruby-grape/grape/issues/2100

The reason was in `ActiveSupport::HashWithIndifferentAccess`, it
is super expensive.

When users use a `Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder`
or `Grape::Extensions::Hashie::Mash::ParamBuilder` parameter builder
there is no change. However, users who use `Grape::Extensions::Hash::ParamBuilder`
must make sure a parameter to be dependent on must be a symbol.

    given :matrix do
      # block here
    end

Benchmark after this fix:

Warming up --------------------------------------
               Given     1.000  i/100ms
              Simple     1.000  i/100ms
Calculating -------------------------------------
               Given      0.804  (± 0.0%) i/s -     49.000  in  61.186831s
              Simple      0.855  (± 0.0%) i/s -     52.000  in  60.926097s

Comparison:
              Simple:        0.9 i/s
               Given:        0.8 i/s - 1.06x  slower

Run Details

12376 of 12481 relevant lines covered (99.16%)

23.24 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	4207.2 (2.7.1, Gemfile)	27 Oct 2020 09:47AM UTC	99.15	Travis Job 4207.2
3	4207.3 (2.7.1, gemfiles/rack1.gemfile)	27 Oct 2020 09:46AM UTC	99.15	Travis Job 4207.3
4	4207.4 (2.7.1, gemfiles/rack2.gemfile)	27 Oct 2020 10:18AM UTC	99.15	Travis Job 4207.4
5	4207.5 (2.7.1, gemfiles/rack_edge.gemfile)	27 Oct 2020 10:19AM UTC	99.15	Travis Job 4207.5
6	4207.6 (2.7.1, gemfiles/rails_edge.gemfile)	27 Oct 2020 10:21AM UTC	99.15	Travis Job 4207.6
7	4207.7 (2.7.1, gemfiles/rails_5.gemfile)	27 Oct 2020 10:21AM UTC	99.15	Travis Job 4207.7
8	4207.8 (2.7.1, gemfiles/rails_6.gemfile)	27 Oct 2020 10:53AM UTC	99.15	Travis Job 4207.8
10	4207.10 (2.7.1, gemfiles/multi_json.gemfile)	27 Oct 2020 10:55AM UTC	0.0	Travis Job 4207.10
11	4207.11 (2.7.1, gemfiles/multi_xml.gemfile)	27 Oct 2020 10:55AM UTC	0.0	Travis Job 4207.11
12	4207.12 (2.6.6, Gemfile)	27 Oct 2020 11:28AM UTC	99.15	Travis Job 4207.12
13	4207.13 (2.6.6, gemfiles/rails_5.gemfile)	27 Oct 2020 11:29AM UTC	99.15	Travis Job 4207.13
14	4207.14 (2.6.6, gemfiles/rails_6.gemfile)	27 Oct 2020 11:31AM UTC	99.15	Travis Job 4207.14
15	4207.15 (2.5.8, Gemfile)	27 Oct 2020 11:31AM UTC	99.15	Travis Job 4207.15
16	4207.16 (2.5.8, gemfiles/rails_5.gemfile)	27 Oct 2020 12:04PM UTC	99.15	Travis Job 4207.16
17	4207.17 (2.5.8, gemfiles/rails_6.gemfile)	27 Oct 2020 12:05PM UTC	99.15	Travis Job 4207.17
18	4207.18 (ruby-head)	27 Oct 2020 12:05PM UTC	34.41	Travis Job 4207.18
21	4207.21 (truffleruby-head)	27 Oct 2020 12:47PM UTC	98.75	Travis Job 4207.21

Source Files on build 4207

Detailed source file information is not available for this build.

ruby-grape / grape / 4207
99%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4207

ruby-grape / grape / 4207 99% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4207

ruby-grape / grape / 4207
99%
master: 97%

README BADGES
x