4213
99%
master: 97%

Ran 28 Oct 2020 08:16AM UTC

Jobs 17

Files 101

Run time 186min

Badge

Embed ▾

pending completion

Build # 4213

Build Type

push

travis-ci

Committed by

dnesteryuk

Commit Message

fix a performance issue with dependent params

Fixes https://github.com/ruby-grape/grape/issues/2100

The reason was in `ActiveSupport::HashWithIndifferentAccess`, it
is super expensive.

When users use a `Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder`
or `Grape::Extensions::Hashie::Mash::ParamBuilder` parameter builder
there is no change. However, users who use `Grape::Extensions::Hash::ParamBuilder`
must make sure a parameter to be dependent on must be a symbol.

    given :matrix do
      # block here
    end

Benchmark after this fix:

Warming up --------------------------------------
               Given     1.000  i/100ms
              Simple     1.000  i/100ms
Calculating -------------------------------------
               Given      0.804  (± 0.0%) i/s -     49.000  in  61.186831s
              Simple      0.855  (± 0.0%) i/s -     52.000  in  60.926097s

Comparison:
              Simple:        0.9 i/s
               Given:        0.8 i/s - 1.06x  slower

Run Details

12376 of 12481 relevant lines covered (99.16%)

23.24 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	4213.2 (2.7.1, Gemfile)	28 Oct 2020 08:16AM UTC	99.15	Travis Job 4213.2
3	4213.3 (2.7.1, gemfiles/rack1.gemfile)	28 Oct 2020 08:16AM UTC	99.15	Travis Job 4213.3
4	4213.4 (2.7.1, gemfiles/rack2.gemfile)	28 Oct 2020 08:16AM UTC	99.15	Travis Job 4213.4
5	4213.5 (2.7.1, gemfiles/rack_edge.gemfile)	28 Oct 2020 08:50AM UTC	99.15	Travis Job 4213.5
6	4213.6 (2.7.1, gemfiles/rails_edge.gemfile)	28 Oct 2020 08:51AM UTC	99.15	Travis Job 4213.6
7	4213.7 (2.7.1, gemfiles/rails_5.gemfile)	28 Oct 2020 08:51AM UTC	99.15	Travis Job 4213.7
8	4213.8 (2.7.1, gemfiles/rails_6.gemfile)	28 Oct 2020 08:51AM UTC	99.15	Travis Job 4213.8
10	4213.10 (2.7.1, gemfiles/multi_json.gemfile)	28 Oct 2020 09:27AM UTC	0.0	Travis Job 4213.10
11	4213.11 (2.7.1, gemfiles/multi_xml.gemfile)	28 Oct 2020 09:27AM UTC	0.0	Travis Job 4213.11
12	4213.12 (2.6.6, Gemfile)	28 Oct 2020 09:28AM UTC	99.15	Travis Job 4213.12
13	4213.13 (2.6.6, gemfiles/rails_5.gemfile)	28 Oct 2020 10:02AM UTC	99.15	Travis Job 4213.13
14	4213.14 (2.6.6, gemfiles/rails_6.gemfile)	28 Oct 2020 10:03AM UTC	99.15	Travis Job 4213.14
15	4213.15 (2.5.8, Gemfile)	28 Oct 2020 10:02AM UTC	99.15	Travis Job 4213.15
16	4213.16 (2.5.8, gemfiles/rails_5.gemfile)	28 Oct 2020 10:03AM UTC	99.15	Travis Job 4213.16
17	4213.17 (2.5.8, gemfiles/rails_6.gemfile)	28 Oct 2020 10:39AM UTC	99.15	Travis Job 4213.17
18	4213.18 (ruby-head)	28 Oct 2020 10:39AM UTC	34.41	Travis Job 4213.18
21	4213.21 (truffleruby-head)	28 Oct 2020 11:22AM UTC	98.75	Travis Job 4213.21

Source Files on build 4213

Detailed source file information is not available for this build.

ruby-grape / grape / 4213
99%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4213

ruby-grape / grape / 4213 99% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4213

ruby-grape / grape / 4213
99%
master: 97%

README BADGES
x