umputun / revdiff
90%
master: 90%

LAST BUILD BRANCH: refs/tags/v1.6.1
DEFAULT BRANCH: master
Repo Added
Token zpy25XdTlXkHx5U3syYGatR9U5X0sk8oe regen
Build 747 Last
Files 71
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH feat/overlay-mouse-support
branch: feat/overlay-mouse-support
CHANGE BRANCH
x
Sync Branches

coverage: 89.581% (+0.03%) from 89.548%
24824759661

Pull #144

github

umputun 
fix(ui): address Copilot findings on overlay mouse integration tests

Copilot flagged three weaknesses in the click-dispatch tests added in
the prior review-fix commit:

1. TestModel_HandleMouse_ClickConfirmsThemeSelect asserted only
   overlay-close, which Manager.HandleMouse guarantees on
   OutcomeThemeConfirmed before Model dispatch runs — and opening via
   mgr.OpenThemeSelect bypassed Model.openThemeSelector, leaving
   themePreview nil so confirmThemeByName was a silent no-op. Now
   opens via the real Model path, uses the test theme catalog, and
   asserts themePreview cleared + activeThemeName set to the clicked
   entry.

2. TestModel_HandleMouse_ClickJumpsAnnotList had the same weak
   assertion. Now asserts pendingAnnotJump set to the cross-file
   target (b.go, line 1) — the real Model-side effect of
   jumpToAnnotationTarget.

3. Base screen buffer used Repeat("line\n", height) which adds a
   trailing newline and makes strings.Split yield height+1 rows,
   shifting Manager.bounds vs real View() output. Added
   makeOverlayBase helper matching overlay/help_test.go::makeBase
   (join without trailing), used across all affected tests.

Click coordinates are now computed against concrete popup layouts
(themeselect popup spans rows 15-23; annotlist popup spans 15-23 with
5 items) so the tests hit known entry rows deterministically.
Pull Request #144: Mouse wheel and click support in overlay popups

169 of 185 new or added lines in 6 files covered. (91.35%)

8185 of 9137 relevant lines covered (89.58%)

458.5 hits per line

Relevant lines Covered
9137 RELEVANT LINES 8185 COVERED LINES
458.5 HITS PER LINE
Source Files on feat/overlay-mouse-support

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24824759661 feat/overlay-mouse-support fix(ui): address Copilot findings on overlay mouse integration tests Copilot flagged three weaknesses in the click-dispatch tests added in the prior review-fix commit: 1. TestModel_HandleMouse_ClickConfirmsThemeSelect asserted only overlay-cl... Pull #144 umputun github
89.58
24824757554 feat/overlay-mouse-support fix(ui): address Copilot findings on overlay mouse integration tests Copilot flagged three weaknesses in the click-dispatch tests added in the prior review-fix commit: 1. TestModel_HandleMouse_ClickConfirmsThemeSelect asserted only overlay-cl... push umputun github
89.58
24824120975 feat/overlay-mouse-support fix(ui): address code review findings for overlay mouse support Bug fixes: - annotlist/themeselect click handlers now check X coordinate against the popup width; clicks on the left/right border or horizontal padding are no-ops (previously sel... Pull #144 umputun github
89.58
24824011843 feat/overlay-mouse-support fix(ui): address code review findings for overlay mouse support Bug fixes: - annotlist/themeselect click handlers now check X coordinate against the popup width; clicks on the left/right border or horizontal padding are no-ops (previously sel... push umputun github
89.58
24823271221 feat/overlay-mouse-support feat(ui): left-click selection in overlay popups Extend the overlay mouse routing so left-click inside a popup selects an item, not just wheel-scrolls it. - annotlist: click on an item row jumps to that annotation (same as Enter) and closes th... push umputun github
89.42
See All Builds (653)

Badge your Repo: revdiff

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh