24824757554
90%
master: 90%

Ran 23 Apr 2026 08:20AM UTC

Jobs 1

Files 59

Run time 1min

Badge

Embed ▾

Committed 23 Apr 2026 08:19AM UTC coverage: 89.581%. Remained the same

Build # 24824757554

Build Type

push

github

Committed by

umputun

Commit Message

fix(ui): address Copilot findings on overlay mouse integration tests

Copilot flagged three weaknesses in the click-dispatch tests added in
the prior review-fix commit:

1. TestModel_HandleMouse_ClickConfirmsThemeSelect asserted only
   overlay-close, which Manager.HandleMouse guarantees on
   OutcomeThemeConfirmed before Model dispatch runs — and opening via
   mgr.OpenThemeSelect bypassed Model.openThemeSelector, leaving
   themePreview nil so confirmThemeByName was a silent no-op. Now
   opens via the real Model path, uses the test theme catalog, and
   asserts themePreview cleared + activeThemeName set to the clicked
   entry.

2. TestModel_HandleMouse_ClickJumpsAnnotList had the same weak
   assertion. Now asserts pendingAnnotJump set to the cross-file
   target (b.go, line 1) — the real Model-side effect of
   jumpToAnnotationTarget.

3. Base screen buffer used Repeat("line\n", height) which adds a
   trailing newline and makes strings.Split yield height+1 rows,
   shifting Manager.bounds vs real View() output. Added
   makeOverlayBase helper matching overlay/help_test.go::makeBase
   (join without trailing), used across all affected tests.

Click coordinates are now computed against concrete popup layouts
(themeselect popup spans rows 15-23; annotlist popup spans 15-23 with
5 items) so the tests hit known entry rows deterministically.

Coverage Stats

8185 of 9137 relevant lines covered (89.58%)

458.5 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	83.91	0.0%	app/ui/themeselect.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	24824757554.1	23 Apr 2026 08:20AM UTC	59	89.58	GitHub Action Run

umputun / revdiff / 24824757554
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24824757554

umputun / revdiff / 24824757554 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24824757554

umputun / revdiff / 24824757554
90%
master: 90%

README BADGES
x