umputun / revdiff / 24824120975

90%

master: 90%

Pull #144

github

fix(ui): address code review findings for overlay mouse support

Bug fixes:
- annotlist/themeselect click handlers now check X coordinate against
  the popup width; clicks on the left/right border or horizontal
  padding are no-ops (previously selected items). Fixes accidental
  theme-persist on mis-clicked chrome.
- themeselect click now updates lastPreviewedName so a subsequent
  keyboard-wheel back to the same entry does not re-emit a preview.

Test improvements:
- Strengthen TestModel_HandleMouse_WheelScrollsCommitInfoOverlay to
  park diffCursor at a non-zero value so wheel-leaking-through would
  be visible.
- Add model-level wheel tests for annotlist and themeselect.
- Add model-level click-to-jump and click-to-confirm integration tests.
- Add horizontal-chrome click tests (border/padding columns).
- Add empty-entries click test for themeselect (panic guard).
- Add Close-clears-bounds test.
- Add no-active-overlay HandleMouse test.

Cleanup:
- Consolidate wheel-step constant: export overlay.WheelStep and have
  app/ui.wheelStep reference it (single source of truth).
- Drop unreachable case KindNone in Manager.HandleMouse switch (early
  return already handles it).
- Clarify unreachable Closed/ThemeCanceled branches in
  handleOverlayMouse via comment (kept for keyboard-path symmetry).
- Drop dead _ = i in commitinfo_test.go loop.
- Restore trailing newline in diffnav_test.go (unrelated formatter
  artifact).

Docs:
- CLAUDE.md: add overlay mouse gotcha (HandleMouse, Manager.bounds
  side effect, Close reset, row offsets, shared WheelStep).
- README, site/docs.html, plugin + codex usage.md: clarify help
  overlay ignores all mouse events, not just wheel.

169 of 185 new or added lines in 6 files covered. (91.35%)

8185 of 9137 relevant lines covered (89.58%)

458.48 hits per line