tarantool / go-luarocks

88%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

Reset

Sync Branches

• master
• bigbes/gh-no-bump-deps
• bigbes/gh-no-engine-isolation
• bigbes/gh-no-fix-progname-test
• bigbes/gh-no-new-logo
• bigbes/gh-no-reeval-luarocks-cmd
• bigbes/gh-no-sysconfdir
• bigbes/lua-bindir-from-executable
• bigbes/tntp-9960-native-client
• bigbes/tntp-9960-native-download
• bigbes/tntp-9960-native-search
• bigbes/tntp-9962-deploy-installed-trees
• bigbes/tntp-9990-git-source-root
• bigbes/tntp-9991-local-registry
• develop

Build # 35207041054

Build Type

push

github

Committed by bigbes

Commit Message

client: hardcode the sysconfdir for the embedded tree

Upstream cfg.init takes the system configuration directory from
hardcoded.SYSCONFDIR and, when that is absent, from detect_sysconfdir,
which reads cfg.lua's own chunk name and takes the directory above
luarocks/core/cfg.lua. Since the embedded modules are compiled once per
process under their embed path, that name is src/src/luarocks/core/cfg.lua
and the guess is the relative "src/src" — so /etc/luarocks/config-5.1.lua
was never read, silently, because a missing config file is not an error.
Before the compile-once change the chunk name did not match the pattern
and the "/etc/luarocks" fallback applied.

Name the directory in hardcoded.lua, as an upstream installer does, so
the answer no longer depends on how the module was loaded.
LUAROCKS_SYSCONFDIR in the environment still overrides it.

Found by tt's test_rocks_with_hardcoded, which mounts a config at
/etc/luarocks and asserts `tt rocks config` shows a value from it.

Coverage Stats

5412 of 6130 relevant lines covered (88.29%)

44.86 hits per line