tarantool / go-luarocks / 33555556082

88%

Build Type

push

github

Committed by bigbes

Commit Message

remote/client: resolve rocks from a local directory

LuaRocks accepts a directory as a server, which is how offline and
air-gapped installs work, but this client reached a registry only over
HTTP. A user with a local mirror could not point the pipeline at it,
and a test suite could not resolve a dependency without the internet.

Add FileRemoteIndex, satisfying the existing RemoteIndex unchanged: it
reads <dir>/manifest and serves artifacts from the same directory,
reusing the shared decoding helpers so only the byte source and the URL
builder differ. LocalServerPath decides what counts as local, mirroring
upstream dir.split_url - a file:// prefix, and any string without a
scheme separator, which is what keeps a Windows path from being read as
a host and agrees with how luarocks reads the same config value.

NewIndex, NewIndexes and OrderedIndex select and compose indexes by
server form, and client and the native engine now build their index
through them, so a directory works everywhere an HTTP server does.

Two consequences worth stating. A multi-server list is now
first-found-wins rather than merged across servers: a merge cannot span
transports, and first-found-wins is what tt's resolver already applies
over the same list, so the facade now agrees with its consumer instead
of differing from it. And OrderedIndex with no members used to answer
"not found", which would have reported a missing rock for an unset
server list - it errors now, keeping "you configured nothing" distinct
from "the registry lacks it".

Closes TNTP-9991

Coverage Stats

139 of 139 new or added lines in 4 files covered. (100.0%)

142 existing lines in 10 files now uncovered.

4890 of 5520 relevant lines covered (88.59%)

39.54 hits per line