skeema / tengo

91%

main: 94%

LAST BUILD ON BRANCH v0.8.9

branch: v0.8.9

CHANGE BRANCH

x

Reset

• v0.8.9
• bulkdropopts
• ci-golint-fix
• col-reorder-algo
• conn-refactor
• dep-golang-19
• fix-gomod-err
• fk-order-mysql55
• flavor-patch
• foreign-keys
• generated-cols
• ghactions
• index-ordering
• introspection-params
• key-col-name-only
• main
• mariadb106
• master
• partitioning
• refs/tags/v0.10.0
• refs/tags/v0.10.1
• refs/tags/v0.10.3
• refs/tags/v0.9.4
• refs/tags/v0.9.5
• refs/tags/v0.9.6
• refs/tags/v0.9.7
• remove-caching
• reuse-containers
• routines
• routines-rebased
• v0.8.1
• v0.8.10
• v0.8.11
• v0.8.12
• v0.8.13
• v0.8.14
• v0.8.15
• v0.8.16
• v0.8.17
• v0.8.18
• v0.8.19
• v0.8.2
• v0.8.3
• v0.8.4
• v0.8.5
• v0.8.7
• v0.8.8
• v0.9.0
• v0.9.1
• v0.9.2
• v0.9.3

Build # 95

Build Type

push

travis-ci

Committed by evanelias

Commit Message

Instance.querySchemaTables(): Fix naming conflict bug between FKs / UKs

Within a single database schema, if a foreign key has the same name as a unique
index, Instance.querySchemaTables() would consistently return an error. This
occurred because an additional join condition is needed to de-dupe this
situation, as both types of constraints are present in MySQL's
information_schema.key_column_usage table.

This commit does the following:

* Add the missing join condition

* Augment error messages in Instance.querySchemaTables() to include schema name

* Provide test coverage by renaming one of the FKs in the fixture data to match
  one of the unique keys

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

1958 of 2153 relevant lines covered (90.94%)

143.75 hits per line