skeema / tengo

88%

main: 94%

LAST BUILD ON BRANCH v0.8.1

branch: v0.8.1

CHANGE BRANCH

x

Reset

• v0.8.1
• bulkdropopts
• ci-golint-fix
• col-reorder-algo
• conn-refactor
• dep-golang-19
• fix-gomod-err
• fk-order-mysql55
• flavor-patch
• foreign-keys
• generated-cols
• ghactions
• index-ordering
• introspection-params
• key-col-name-only
• main
• mariadb106
• master
• partitioning
• refs/tags/v0.10.0
• refs/tags/v0.10.1
• refs/tags/v0.10.3
• refs/tags/v0.9.4
• refs/tags/v0.9.5
• refs/tags/v0.9.6
• refs/tags/v0.9.7
• remove-caching
• reuse-containers
• routines
• routines-rebased
• v0.8.10
• v0.8.11
• v0.8.12
• v0.8.13
• v0.8.14
• v0.8.15
• v0.8.16
• v0.8.17
• v0.8.18
• v0.8.19
• v0.8.2
• v0.8.3
• v0.8.4
• v0.8.5
• v0.8.7
• v0.8.8
• v0.8.9
• v0.9.0
• v0.9.1
• v0.9.2
• v0.9.3

Build # 54

Build Type

push

travis-ci

Committed by evanelias

Commit Message

Fix sort order for foreign keys, especially re: underscores

SHOW CREATE TABLE shows foreign keys sorted by name, which Go La Tengo attempts
to reproduce when performing schema introspection. However, a BINARY sort order
is needed to correctly match the order in SHOW CREATE TABLE. In particular,
underscores need to be sorted as they are in ascii (after uppercase chars but
before lowercase chars), rather than as they are in non-binary MySQL collations
(after all chars regardless of case).

This commit also has TengoIntegrationSuite.TestInstanceSchemaIntrospection() now
confirm that foreign keys are in the correct order, by virtue of adding several
foreign keys to a fixture table that trigger the previous bug condition.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

1755 of 2002 relevant lines covered (87.66%)

104.8 hits per line