skeema / tengo

92%

main: 94%

LAST BUILD ON BRANCH bulkdropopts

branch: bulkdropopts

CHANGE BRANCH

x

Reset

• bulkdropopts
• master
• remove-caching
• dep-golang-19
• index-ordering
• foreign-keys
• v0.8.1
• reuse-containers
• v0.8.2
• v0.8.3
• v0.8.4
• v0.8.5
• col-reorder-algo
• v0.8.7
• v0.8.8
• v0.8.9
• v0.8.10
• v0.8.11
• v0.8.12
• v0.8.13
• routines
• routines-rebased
• v0.8.14
• ci-golint-fix
• v0.8.15
• v0.8.16
• fk-order-mysql55
• v0.8.17
• v0.8.18
• partitioning
• v0.8.19
• generated-cols
• v0.9.0
• key-col-name-only
• v0.9.1
• flavor-patch
• v0.9.2
• v0.9.3
• ghactions
• main
• refs/tags/v0.9.4
• refs/tags/v0.9.5
• refs/tags/v0.9.6
• refs/tags/v0.9.7
• conn-refactor
• introspection-params
• refs/tags/v0.10.0
• refs/tags/v0.10.1
• mariadb106
• fix-gomod-err
• refs/tags/v0.10.3

Build # 161

Build Type

push

travis-ci

Committed by evanelias

Commit Message

New options struct for bulk table drops (API-breaking change)

This commit changes the second arg of Instance.DropSchema() and
Instance.DropTablesInSchema() to be a new struct, BulkDropOptions, which
permits configurable concurrency levels.

This is a breaking change, which is acceptable since this package is still
pre-v1.0.0. Ordinarily this is still best avoided, however, some environments
stall on concurrent table drops due to dict_sys mutex contention.

This commit also changes throttled-concurrency code paths to use external
package github.com/nozzle/throttler, rather than the previous approach of
temporarily tweaking SetMaxOpenConns and using golang.org/x/sync/errgroup.

Run Details

56 of 56 new or added lines in 2 files covered. (100.0%)

2532 of 2758 relevant lines covered (91.81%)

156.69 hits per line