• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

share / sharedb
96%
master: 97%

Build:
Build:
LAST BUILD BRANCH: fix-lib-hasown-lagacy
DEFAULT BRANCH: master
Repo Added 10 Mar 2016 07:44AM CUT
Files 39
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH null-milestone-db
branch: null-milestone-db
CHANGE BRANCH
x
Reset
  • null-milestone-db
  • 1.x-beta
  • ServerStream-clone
  • Teamwork-fix-whenNothingPending
  • add-connection-tests
  • after-write
  • async-2
  • backend-docs
  • broken-connection
  • bug-fix/broken-hard-rollback
  • bug-fix/broken-presence-hardrollback
  • close-milestone-database
  • db-method-options
  • delay-op-for-query-poll
  • delete-docs
  • doc-images-with-height
  • downgrade-stack-warn
  • error-codes
  • eslint
  • examples-ws-update
  • fetch-snapshot-middleware
  • fix-272
  • fix-docs
  • fix-flaky-test
  • fix-lib-hasown-lagacy
  • fix-projection-queries
  • fix-tests-sync-unsub
  • fix-textarea-example
  • getops-options
  • handshake
  • held-ops
  • initialise-paused
  • leadership-readme-update
  • logger-override
  • master
  • middleware-docs-reply
  • op-batch
  • otapply-rollback
  • presence
  • presence-call-each
  • presence-destroy
  • presence-example
  • presence-resubscribe
  • read-docs-middleware
  • readSnapshots-context
  • readSnapshots-specific-errors
  • remove-deprecated-middleware
  • remove-duplicated-type
  • remove-mingo-dep
  • reorganize-pubsub-adapters
  • reply-middleware
  • revert-263-readSnapshots-context
  • revert-shallow-copy-op
  • run-sharedb-mongo-tests
  • server-plugin-query
  • show
  • silence-logger-in-tests
  • snapshot-by-timestamp
  • snapshot-request-test
  • snapshot-throw
  • test-error-visibility
  • test-fixes
  • test-query-poll-doc
  • unsubscribe-bug
  • update-dependencies
  • update-examples
  • update-snapshot-docs
  • use-async
  • use-loglevel
  • v0.11.35
  • v0.11.36
  • v0.11.37
  • v1.0.0
  • v1.0.0-beta.1
  • v1.0.0-beta.10
  • v1.0.0-beta.11
  • v1.0.0-beta.12
  • v1.0.0-beta.13
  • v1.0.0-beta.14
  • v1.0.0-beta.15
  • v1.0.0-beta.16
  • v1.0.0-beta.17
  • v1.0.0-beta.18
  • v1.0.0-beta.19
  • v1.0.0-beta.2
  • v1.0.0-beta.20
  • v1.0.0-beta.21
  • v1.0.0-beta.22
  • v1.0.0-beta.23
  • v1.0.0-beta.24
  • v1.0.0-beta.25
  • v1.0.0-beta.26
  • v1.0.0-beta.27
  • v1.0.0-beta.28
  • v1.0.0-beta.29
  • v1.0.0-beta.3
  • v1.0.0-beta.30
  • v1.0.0-beta.31
  • v1.0.0-beta.4
  • v1.0.0-beta.5
  • v1.0.0-beta.6
  • v1.0.0-beta.7
  • v1.0.0-beta.8
  • v1.1.0
  • v1.2.0
  • v1.2.1
  • v1.3.0
  • v1.3.1
  • v1.3.2
  • v1.3.3
  • v1.3.4
  • v1.4.0
  • v1.4.1
  • v1.4.2
  • v1.5.0
  • v2
  • yet-another-presence

pending completion
882

push

travis-ci

Alec Gibson
Commonise valid version logic

This change introduces a `util.isValidVersion` method, which is common
between `SnapshotRequest` and `MilestoneDB`, and makes sure we're
consistent in what constitutes a valid version.

We check that versions are either `null` or a positive integer. We
reject `undefined`, based on the idea that `null` means that you meant
to set something to `null`, but with `undefined` that may not be the
case. It's also consistent with the version that can be passed into
`getOps` (ie `null` has the special meaning of "please give me the
latest version").

1090 of 1311 branches covered (83.14%)

12 of 12 new or added lines in 5 files covered. (100.0%)

2294 of 2401 relevant lines covered (95.54%)

399.18 hits per line

Relevant lines Covered
Build:
Build:
2401 RELEVANT LINES 2294 COVERED LINES
399.18 HITS PER LINE
Source Files on null-milestone-db
  • List 0
  • Changed 3
  • Source Changed 2
  • Coverage Changed 3
Loading...
Coverage∆FileLinesRelevantCoveredMissedHits/LineBranch HitsBranch Misses
No data available in table
Showing 0 to 0 of 0 entries
  • Previous
  • Next

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
882 null-milestone-db Commonise valid version logic This change introduces a `util.isValidVersion` method, which is common between `SnapshotRequest` and `MilestoneDB`, and makes sure we're consistent in what constitutes a valid version. We check that versions are eit... push 31 Aug 2018 07:38AM CUT Alec Gibson travis-ci pending completion  
881 null-milestone-db Remove `MilestoneDB._isValidVersion` This method is now just a wrapper around `util.isValidVersion`. Given that any subclasses will also have access to the `util` module, we remove this method and allow the implementors to determine how to decide... Pull #244 31 Aug 2018 07:29AM CUT web-flow travis-ci pending completion  
880 null-milestone-db Remove `MilestoneDB._isValidVersion` This method is now just a wrapper around `util.isValidVersion`. Given that any subclasses will also have access to the `util` module, we remove this method and allow the implementors to determine how to decide... push 31 Aug 2018 07:28AM CUT Alec Gibson travis-ci pending completion  
872 null-milestone-db Commonise valid version logic This change introduces a `util.isValidVersion` method, which is common between `SnapshotRequest` and `MilestoneDB`, and makes sure we're consistent in what constitutes a valid version. We check that versions are eit... push 30 Aug 2018 09:12AM CUT Alec Gibson travis-ci pending completion  
869 null-milestone-db Improve test coverage for `SnapshotRequest.onConnectionStateChanged` This change improves `SnapshotRequest` test coverage to 100%. Our current test for checking that a dropped connection works didn't actually fail properly when removing `this.se... push 30 Aug 2018 09:06AM CUT Alec Gibson travis-ci pending completion  
870 null-milestone-db Improve test coverage for `SnapshotRequest.onConnectionStateChanged` This change improves `SnapshotRequest` test coverage to 100%. Our current test for checking that a dropped connection works didn't actually fail properly when removing `this.se... Pull #244 30 Aug 2018 09:06AM CUT web-flow travis-ci pending completion  
868 null-milestone-db Commonise valid version logic This change introduces a `util.isValidVersion` method, which is common between `SnapshotRequest` and `MilestoneDB`, and makes sure we're consistent in what constitutes a valid version. We check that versions are eit... Pull #244 30 Aug 2018 07:33AM CUT web-flow travis-ci pending completion  
867 null-milestone-db Commonise valid version logic This change introduces a `util.isValidVersion` method, which is common between `SnapshotRequest` and `MilestoneDB`, and makes sure we're consistent in what constitutes a valid version. We check that versions are eit... push 30 Aug 2018 07:33AM CUT Alec Gibson travis-ci pending completion  
866 null-milestone-db Add argument checking tests for MilestoneDB Pull #244 29 Aug 2018 12:07PM CUT web-flow travis-ci pending completion  
865 null-milestone-db Add argument checking tests for MilestoneDB push 29 Aug 2018 12:06PM CUT Alec Gibson travis-ci pending completion  
See All Builds (1414)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc