share / sharedb / 882

96%

master: 97%

push

travis-ci

Commonise valid version logic

This change introduces a `util.isValidVersion` method, which is common
between `SnapshotRequest` and `MilestoneDB`, and makes sure we're
consistent in what constitutes a valid version.

We check that versions are either `null` or a positive integer. We
reject `undefined`, based on the idea that `null` means that you meant
to set something to `null`, but with `undefined` that may not be the
case. It's also consistent with the version that can be passed into
`getOps` (ie `null` has the special meaning of "please give me the
latest version").

1090 of 1311 branches covered (83.14%)

12 of 12 new or added lines in 5 files covered. (100.0%)

2294 of 2401 relevant lines covered (95.54%)

399.18 hits per line