share / sharedb

97%

master: 97%

LAST BUILD ON BRANCH presence-resubscribe

branch: presence-resubscribe

CHANGE BRANCH

x

Reset

• presence-resubscribe
• master
• v0.11.35
• v0.11.36
• v0.11.37
• db-method-options
• v1.0.0-beta.1
• v1.0.0-beta.3
• v1.0.0-beta.2
• doc-images-with-height
• v1.0.0-beta.4
• v1.0.0-beta.5
• v1.0.0-beta.6
• v1.0.0-beta.7
• reorganize-pubsub-adapters
• v1.0.0-beta.8
• add-connection-tests
• leadership-readme-update
• delete-docs
• read-docs-middleware
• remove-mingo-dep
• v1.0.0-beta.10
• v1.0.0-beta.11
• v1.0.0-beta.12
• fetch-snapshot-middleware
• close-milestone-database
• null-milestone-db
• snapshot-request-test
• v1.0.0-beta.13
• v1.0.0-beta.14
• use-loglevel
• logger-override
• otapply-rollback
• v1.0.0-beta.15
• v1.0.0-beta.16
• snapshot-by-timestamp
• v1.0.0-beta.17
• readSnapshots-context
• v1.0.0-beta.18
• update-snapshot-docs
• v1.0.0-beta.19
• revert-263-readSnapshots-context
• fix-272
• v1.0.0-beta.20
• reply-middleware
• v1.0.0-beta.21
• middleware-docs-reply
• Teamwork-fix-whenNothingPending
• v1.0.0-beta.22
• v1.0.0-beta.23
• examples-ws-update
• getops-options
• backend-docs
• eslint
• ServerStream-clone
• error-codes
• remove-deprecated-middleware
• after-write
• fix-projection-queries
• downgrade-stack-warn
• presence
• update-dependencies
• test-query-poll-doc
• yet-another-presence
• v1.0.0-beta.24
• update-examples
• delay-op-for-query-poll
• v1.0.0-beta.25
• revert-shallow-copy-op
• v1.0.0-beta.26
• v1.0.0-beta.27
• 1.x-beta
• test-error-visibility
• v1.0.0-beta.28
• test-fixes
• v1.0.0-beta.29
• show
• v1.0.0-beta.30
• v1.0.0-beta.31
• v1.0.0
• readSnapshots-specific-errors
• v1.1.0
• silence-logger-in-tests
• broken-connection
• handshake
• use-async
• v1.2.0
• v1.2.1
• fix-docs
• v1.3.0
• async-2
• v1.3.1
• server-plugin-query
• unsubscribe-bug
• v1.3.2
• presence-call-each
• fix-textarea-example
• v1.3.3
• fix-tests-sync-unsub
• run-sharedb-mongo-tests
• v1.3.4
• presence-example
• v1.4.0
• fix-flaky-test
• presence-destroy
• v1.4.1
• held-ops
• initialise-paused
• snapshot-throw
• v1.4.2
• op-batch
• v1.5.0
• v2

Build # 1380

Build Type

Pull #356

travis-ci

Committed by web-flow

Commit Message

Fix presence re-subscribe after destroy

This change fixes the following edge case:

  1. Create a `Presence` object
  2. Subscribe the presence
  3. Destroy the presence
  4. Create a new `Presence` object for the same channel on the same
     `Connection` object
  5. Attempt to re-subscribe
  6. `Agent` ignores the re-subscribe request, because the `seq` was
     reset to `1` on the new `Presence` object, but is still `2` on the
     `Agent`

We fix this by using a universal `_presenceSeq` counter on the
`Connection`, which is never reset, meaning that all presence messages
will have a strictly higher number than one another.

Pull Request Pull Request #356: Fix presence re-subscribe after destroy

Run Details

1407 of 1632 branches covered (86.21%)

2 of 2 new or added lines in 2 files covered. (100.0%)

3075 of 3159 relevant lines covered (97.34%)

535.18 hits per line