share / sharedb / 870

96%

master: 97%

Pull #244

travis-ci

Improve test coverage for `SnapshotRequest.onConnectionStateChanged`

This change improves `SnapshotRequest` test coverage to 100%.

Our current test for checking that a dropped connection works didn't
actually fail properly when removing `this.sent = false` from
`SnapshotRequest._onConnectionStateChanged`, so an improved test has
been written that use middleware to wait until the request has
definitely been sent, before dropping the connection and reconnecting.

It also adds a previously uncovered test case for checking that the
connection cannot send the same request multiple times, by using a
similar setup to the rewritten dropped connection case.

This change also adds some documentation recording why we might want to
reset `this.sent = false`, because just looking at the code it's
unclear why we would ever want to do that.

1089 of 1309 branches covered (83.19%)

40 of 40 new or added lines in 6 files covered. (100.0%)

2293 of 2400 relevant lines covered (95.54%)

401.56 hits per line