share / sharedb

97%

master: 97%

LAST BUILD ON BRANCH presence-call-each

branch: presence-call-each

CHANGE BRANCH

x

Reset

• presence-call-each
• master
• v0.11.35
• v0.11.36
• v0.11.37
• db-method-options
• v1.0.0-beta.1
• v1.0.0-beta.3
• v1.0.0-beta.2
• doc-images-with-height
• v1.0.0-beta.4
• v1.0.0-beta.5
• v1.0.0-beta.6
• v1.0.0-beta.7
• reorganize-pubsub-adapters
• v1.0.0-beta.8
• add-connection-tests
• leadership-readme-update
• delete-docs
• read-docs-middleware
• remove-mingo-dep
• v1.0.0-beta.10
• v1.0.0-beta.11
• v1.0.0-beta.12
• fetch-snapshot-middleware
• close-milestone-database
• null-milestone-db
• snapshot-request-test
• v1.0.0-beta.13
• v1.0.0-beta.14
• use-loglevel
• logger-override
• otapply-rollback
• v1.0.0-beta.15
• v1.0.0-beta.16
• snapshot-by-timestamp
• v1.0.0-beta.17
• readSnapshots-context
• v1.0.0-beta.18
• update-snapshot-docs
• v1.0.0-beta.19
• revert-263-readSnapshots-context
• fix-272
• v1.0.0-beta.20
• reply-middleware
• v1.0.0-beta.21
• middleware-docs-reply
• Teamwork-fix-whenNothingPending
• v1.0.0-beta.22
• v1.0.0-beta.23
• examples-ws-update
• getops-options
• backend-docs
• eslint
• ServerStream-clone
• error-codes
• remove-deprecated-middleware
• after-write
• fix-projection-queries
• downgrade-stack-warn
• presence
• update-dependencies
• test-query-poll-doc
• yet-another-presence
• v1.0.0-beta.24
• update-examples
• delay-op-for-query-poll
• v1.0.0-beta.25
• revert-shallow-copy-op
• v1.0.0-beta.26
• v1.0.0-beta.27
• 1.x-beta
• test-error-visibility
• v1.0.0-beta.28
• test-fixes
• v1.0.0-beta.29
• show
• v1.0.0-beta.30
• v1.0.0-beta.31
• v1.0.0
• readSnapshots-specific-errors
• v1.1.0
• silence-logger-in-tests
• broken-connection
• handshake
• use-async
• v1.2.0
• v1.2.1
• fix-docs
• v1.3.0
• async-2
• v1.3.1
• server-plugin-query
• presence-resubscribe
• unsubscribe-bug
• v1.3.2
• fix-textarea-example
• v1.3.3
• fix-tests-sync-unsub
• run-sharedb-mongo-tests
• v1.3.4
• presence-example
• v1.4.0
• fix-flaky-test
• presence-destroy
• v1.4.1
• held-ops
• initialise-paused
• snapshot-throw
• v1.4.2
• op-batch
• v1.5.0
• v2

Build # 1389

Build Type

Pull #359

travis-ci

Committed by web-flow

Commit Message

Fix `Presence._callEachOrEmit`

At the moment, there's a bug where we:

  1. Start disconnected
  2. Submit a presence subscribe request with **no callback**
  3. Connect
  4. The presence then subscribes and calls each callback, but doesn't
     check whether the callback is truthy, which throws

We could check callbacks when we first assign them to the internal map,
but it's quite nice for debugging to see an `undefined` callback
attached to a `seq`.

Therefore, we should handle callbacks not existing when actually
calling them, which `Doc` already does.

This change moves the `Doc` `callEach` method into `utils`, where we can
also use it in `Presence`.

Pull Request Pull Request #359: Fix `Presence._callEachOrEmit`

Run Details

1405 of 1630 branches covered (86.2%)

17 of 17 new or added lines in 3 files covered. (100.0%)

3073 of 3157 relevant lines covered (97.34%)

536.13 hits per line