noironetworks / aci-containers
63%
master: 63%

LAST BUILD BRANCH: snat-svc-fix
DEFAULT BRANCH: master
Repo Added
Files 48
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH snat-svc-fix
branch: SELECT
CHANGE BRANCH
x

coverage: 63.383% (+0.4%) from 63.028%
11917

Pull #1706

travis-pro

jeffinkottaram 
Fix per-service SNAT IP assignment for no-SnatIp policies

Two bugs are fixed:

1. Namespace-level no-SnatIp SNAT policies with multiple LoadBalancer
   services incorrectly assigned all LB external IPs to all pods.
   The controller now tags each global info entry with the originating
   service key. The hostagent filters SNAT UIDs per-pod by checking
   service endpoint membership, ensuring each pod only egresses with
   the external IP of the service it belongs to.

2. After hostagent pod restarts, namespace-level no-SnatIp policies
   lost their service SNAT entries because pod events did not evaluate
   service membership for the namespace-scoped policy path. The
   namespace-scoped branch now checks for matching services when
   processing pod events, consistent with the label-scoped path.

Additionally, two  inconsistencies are corrected:

1. The deployment path for no-SnatIp policies incorrectly matched
deployment metadata labels against service pod selectors. Since
services select pods (not deployments), and pod template changes
produce new pod events handled separately, this check was both
inaccurate and redundant. It is removed.

2. Explicit-SnatIp policies matching services now consistently apply the
specified SNAT IP to the service's backend pods across all policy
evaluation paths
Pull Request #1706: Fix per-service SNAT IP assignment for no-SnatIp policies

57 of 87 new or added lines in 2 files covered. (65.52%)

1119 existing lines in 9 files now uncovered.

13628 of 21501 relevant lines covered (63.38%)

0.72 hits per line

Relevant lines Covered
21501 RELEVANT LINES 13628 COVERED LINES
0.72 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
11917 snat-svc-fix Fix per-service SNAT IP assignment for no-SnatIp policies Two bugs are fixed: 1. Namespace-level no-SnatIp SNAT policies with multiple LoadBalancer services incorrectly assigned all LB external IPs to all pods. The controller now tags each... Pull #1706 jeffinkottaram travis-pro
63.38
11918 snat-svc-fix Merge 49b052d4b into a47530507 Pull #1706 web-flow travis-pro
63.16
11916 snat-svc-fix-test Fix per-service SNAT IP assignment for no-SnatIp policies Two bugs are fixed: 1. Namespace-level no-SnatIp SNAT policies with multiple LoadBalancer services incorrectly assigned all LB external IPs to all pods. The controller now tags each... push jeffinkottaram travis-pro
63.4
11914 mmr-6.1.1 Merge pull request #1724 from noironetworks/backport-fix-hpp-direct-minor-bug [mmr-6.1.1] Fix missing return in handleRemIpContUpdate push web-flow travis-pro
63.03
11913 backport-fix-hpp-direct-minor-bug Fix missing return in handleRemIpContUpdate Fixes a bug where after deleting a HostprotRemoteIpContainer CR (when not found in nsRemoteIpCont cache), the code continued to attempt updating the deleted CR, causing 'UID field not found' errors. (c... Pull #1724 allenantony-oc travis-pro
63.0
11911 backport-fix-hpp-direct-minor-bug Merge 23c965613 into 360c19205 Pull #1724 web-flow travis-pro
63.01
11909 master Merge pull request #1723 from noironetworks/fix-hpp-direct-minor-bug Fix missing return in handleRemIpContUpdate push web-flow travis-pro
63.03
11908 fix-hpp-direct-minor-bug Merge 1b3d468e5 into fcc91fc3a Pull #1723 web-flow travis-pro
63.04
11907 fix-hpp-direct-minor-bug Fix missing return in handleRemIpContUpdate Fixes a bug where after deleting a HostprotRemoteIpContainer CR (when not found in nsRemoteIpCont cache), the code continued to attempt updating the deleted CR, causing 'UID field not found' errors. Pull #1723 allenantony-oc travis-pro
62.99
11904 mmr-6.1.1 Merge pull request #1722 from noironetworks/backport-revert-fix-repeated-netpol-file-creation [mmr-6.1.1] Revert "Fix repeated netpol file recreation due to map ordering in CR updates" push web-flow travis-pro
63.0
See All Builds (5058)