noironetworks / aci-containers

57%

master: 69%

LAST BUILD ON BRANCH deadlock-fix-5.2.3.1

branch: deadlock-fix-5.2.3.1

CHANGE BRANCH

x

Reset

• deadlock-fix-5.2.3.1
• coveralls-support
• master
• improve-logs
• enable-es
• alpine-upgrade
• remove-gometalinter
• netflow-update
• add-opflex-uts
• erspan-crd
• defer-file-close
• upgrade-netlink
• docker-opflex-build
• remove-inst-tag-support
• nmp-np-fix
• remove-cfconfig
• remove-disabled-tests
• upgrade-kube-1.19.3
• opflex-tsan-enable
• lgtm-codacy-issues
• es-issue
• gitignore-coverage
• judith
• netflow-UT
• cf-cleanup
• cluster_level_podsel
• netflow
• mtufault
• crd-examples
• opflex-server-gbpinspect
• iptables-addons
• 5.2.1.0
• 5.1.3.0
• judith-xtables-addon
• mtuf
• docker-controller-base
• aci-cni-image-base
• gbp-netflow
• uuid
• netflow-MO
• serv-t
• interface-ip-issue
• judith-interfacr-ip-issue
• osp-4.6-flavor
• abhi-4.6-flavor
• remove-disableyumrepo
• abhi-4.6-flavor-master
• alpine3.12.3
• gbp-base-image
• master-remove-disablerepo
• netflow-ver
• netflow-test
• same-ovs
• grpc-inspect
• faults_annotate
• prom-cpp-0.12.1
• snat-log
• 5.1.3.1
• goplantuml
• erspan-UTs
• remove-cf-classes
• erspan-podif
• debug-hostagent-podif
• podifs-always
• service-topokeys
• crds-seq
• go-vendor-update
• api-migration
• cleanup
• api-mig
• erspan-sync
• macalloc
• erspan-sync-node
• erspan-default
• default-gbpserver-inspect-config
• remove-cpp-artifacts
• gbpserver-static-analysis
• remove-defaults
• erspan-overlay
• disable-etcd-overlay
• internal-netpol
• ipMac
• dup-ipv6-addrs
• erspan-update
• merge-opflex-containers
• dns-service
• judith-crash-fix-bp
• 5.1.3.2
• ipBasedMacAlloc
• topologyaware
• ipmac-issue
• ipmac-issue-judith
• 5.1.3.3
• kwai
• remove-unused-code
• cleanup-cf-ipam
• gbpserver-send-root-children
• remove-prom-enable
• serv-sesaffinity
• remove-godep-vendor
• sessionAffinty-fix-kwai
• qos-fixes
• remove-toml
• qos-policy
• Acik8s21
• k8s21-kwai-bp
• qos-labelsel
• qos-key
• qos-apic
• netflow-apic
• service-ses
• service-ses-bp-kwai
• remove-opflex-server-from-priv
• epdec
• qos-policy-merge
• sctp-changes
• sctp-kwai-bp
• update-ovsdb-deps
• judith-rev
• faults_annot
• snat-fix
• snat-fix-bp
• snat-fix-judith-bp
• 5.1.3.4
• lint-cleanup
• cachedn
• update-cni-plugins
• globalinfosync1
• globalinfosyncv2
• globalinfosyncv3
• backport-kwai
• globalsynclogs
• backport-kwaii
• droplog-crd
• snatsyncUT
• qos-fix
• qos-fix-kwai
• wait-for-network-enable
• backport-wait-for-network-enable
• revert-podif-kwai
• increase-wait-for-network
• goveralls
• goveralls-kwai
• erspan-src
• netattach
• 5.2.1.1
• erspan-kwai
• servicedns
• fix-typo
• abhi-esx-flavor-add
• abhi-esx-kwai
• podif-scale
• snat-issue
• newaccprovoperator
• newnetattach
• topology_hints
• 5.2.1.2
• newaccprovoperator-opflexODev
• opflexODev-july19
• fabricPathDnFix-trial
• flakytest
• travis
• kubectl-version-update
• accprovfix
• 5.2.3.0
• abhi-flv-svc
• snatlock
• backport-snat
• crdversion
• gomod
• hostagentfix
• revert
• apooaug12
• syncmap
• test-nackport-kwai
• buildwithrace
• gateway_fix
• buildwithrace-beforefix
• kwai-race
• vmmInjectedLabel
• vmm-inj
• ep-registry
• opflexODev-aug23-kwai
• cont-race
• opflexODev-aug23
• syncglobalinfocache
• nodeinfo_clusterreport
• race-master
• abhi-ocp-esx-4.8
• nodeinfo-port-exhaust
• race-kwai-fix
• snat-ut
• ipam-leak-master
• version_details
• syncglobal-comment
• sriov
• ipam_1
• snat-ut-fix
• makeMTUConfigurable
• ntd
• snat-policy-race
• snat-race
• netpol_reg
• revert_netpol
• nodeinfo-kwai
• snat-kwai
• globalInfoCache-kwai
• fix-snat-race
• managedupgrade
• snat-race-kwai
• improve-logging
• issue260
• smartnic
• apicapi-logging
• fail-fast
• revise-logging
• abhi-cfg-map
• kmr2
• disablestats
• opflex-dev
• master-bkp
• svc-graph
• debug-log
• svc-redirect
• snat-ipExhausted-status
• snat-portRange
• snat-portrange
• apic-log
• snat-panic
• snat-panic-fix
• rdconfig
• fix_RdConfig
• version_change_b
• race-build-cmd
• rdconfig_del_handler
• fabric-path
• port-exhausted
• net_pol_patch
• oc_debug
• ipam_host_controller
• container-logs
• alpine
• 5.2.3.1
• kmr2_revert_v1
• master_revert_v1
• snat-configmap
• snat-config-kwai
• 5.2.3.2
• apic-cko
• apic-cert
• snatglobalinfo-sharding
• revert_netpol_revert
• snat-sync
• CSCwa32900-fix
• snat-logging
• websocket
• apic-version
• apic-version-kmr2
• apic-refresh
• snat-log-kmr2
• vmm-labels
• vmm-labels-kmr2
• apic-refresh-kmr2
• kmr2-opflexodev-fix
• logging
• ipam-leaks-fix
• opflexdevice-fix
• opflexdevice-kmr2
• bosch_issue
• snat-uuid-missing
• lock-order
• log_fix
• deadlock-fix-kmr2
• snat-uuid
• kmr2-snat-uuid
• kmr2-ipam-leak
• log_fix_2
• log_fix_kmr2
• opflex-cleanup
• subscription_fix
• kmr2-opflex-cleanup
• sub_delay
• kmr2_sub_delay
• delay_subs_2
• delay_subs_refresh
• clear_child_subs
• backport_subs
• race-fix
• kmr2-race-fix
• cache-fix
• unregister_ipam_fix
• unregister_ipam_fix_master
• opflexlocalinfo-fix
• opflexlocalinfo-fix-kmr2
• bumpk8s
• Add_goveralls@v0.0.8_for_CI
• localinfo-fix-kmr2
• mg-patch-2
• mg-localinfo-fix-kmr2
• mg-opflexlocalinfo-fix
• unregister_ipam_fix_kmr2
• bumpk8s-kmr2
• ipleak-issue-fix
• dependabot-fix
• ipam-exhaustion-fix
• ipam-exhaustion-fix-kmr2
• dependabot-fix-kmr2
• size-limit-remove
• size-limit-remove-backported
• size-limit-remove-kmr2
• snat-uuid-dummy
• snat-uuid-dep
• snat-uuid-dep-kmr2
• pprof_ha
• pprof_ha_kmr2
• mg-waitforcachesync-kmr2
• CSCwa32900-fix-master
• CSCwa32900-fix-kmr2
• pod-del-fix
• object_name_to_uuid
• snat_services
• kmr2-fallback
• kmr2_obj_uuid_fix
• pod-del-fix-mkr2
• fallback-testcase-fix
• fallback-testcase-fix-kmr2
• refresh-fix
• refresh-fix-kmr2
• logfilesize
• update-cache-dns
• kmr2-update-cache-dns
• too-large-rv
• too-large-rv-kmr2
• too-large-rv-fix
• too-large-rv-fix-kmr2
• log-file-size-m
• 5.2.3.2rc7
• port-range-support
• 5.2.3.3
• hpp-single-request
• abhi-4.9-4.10-esx
• abhi-4.8-9-10-flavors
• abhi-cherrypick-flavors
• snatglobalinfo-sharding-kmr2
• log-file-size-kmr2
• revert-apic-struct-commit
• batching-hpp-master
• batching-hpp-kmr2
• ep-ready
• ep-ready-kmr2
• ep-ready_kmr2
• delay-master
• delay-kmr2
• snat-ip-overlap
• snat-ip-overlap-kmr2
• dependabot-fix_master
• dependabot-fix_kmr2
• kmr2_rh_operator_certification
• dpu
• hpp-remip-cont
• abhi-rke
• globalinfo-sync-time-test
• add-panic
• add-panic-kmr2
• kmr2-add-panic
• kmr2-globalinfo-sync-time-test
• ep-ready-configurable
• pod-succeeded-kmr2
• ep-ready-configurable-kmr2
• pod-succeeded-backport
• adding_extern_from_pod_param_kmr2
• add_extern_from_pod_arg_kmr2
• add_extern_from_pod_arg
• sleep_time_snat
• broken-ns-update-req-fix
• broken-ns-update-req-fix-kmr2
• rh_updated_hosted_certification
• health_index_check
• 5.2.3.3-revert-batch-hpp
• revert-hpp-batching
• 5.2.3.4
• cluster_report_get
• openshift-4.11-openstack-flavor
• openshift-4.11-openstack-flavor-kmr2
• nodeServiceMetaCache-lock
• nodeServiceMetaCache-lock-kmr2
• cluster_report_get_kmr2
• cm-name-fix
• cm-name-fix-kmr2
• acikubectl-fix
• acikubectl-fix-kmr2
• 5.2.3.5
• pbr_delay_master
• pbr_delay_kmr2
• sumit-update-rhel-rpm
• temp-5.2.3.4
• hpp-optimization
• kmr2-hpp-optimization
• hpp-optimization-kmr2
• endointslice-update-fix
• sleep_time_snat_kmr2
• 5.2.3.6
• endointslice-update-fix-kmr2
• dualstack-backport
• coverall-travis-pro
• dependabot/go_modules/k8s.io/kubernetes-1.25.10
• cni_chaining_hostagent
• dhcp-fix
• bad-endpoint-slice-check
• address-more-linter-complaints
• update_after_delete_fix
• cni_chaining_controller
• cleanup_controller_chained_mode_part1
• cluster-report-collect-network-policy
• linter-setup
• dependabot/go_modules/k8s.io/kubernetes-1.25.11
• adj_failure_handling
• rev-gbpserver-deps
• upgrade_to_k8s1.27
• misc_part_1
• upgrade_to_k8s1.27-kmr2
• backport-travis
• travis-backport-kmr2
• upgrade_to_k8s1.27_kmr2
• 5.2.3.7
• cluster-report-collect-pod-log-history
• more-linter-fixes
• alt_nad
• misc_fixes
• create_pdom_pool
• pdom_pool2
• new-master
• cleanup_final
• add_non_per_port_mode
• error_handling_ut
• fix_2629
• add_nad_annotation
• ha_sync_failure
• vmm-dom-fix
• change_globalmode_semantics
• reconnect-timeout
• fixes_globalmode
• fixes
• build_chained_mode
• configmap_nad
• update-protobuf
• fixes_nadvlanmap
• ocp-4.13-flavors
• lbip-via-annotation
• shared_delete_fix
• vm-mig-fix
• program_on_first_pod
• expose-metrics
• staticpath_crd
• fix_crd
• abhi-fix-cve
• lockfix
• primary_unchained
• default_unchained
• anmol372-patch-test-cicd
• multus_cp_error
• abhi-cves-fix
• abhi-fix-istio-cve
• use-goenv
• dynamic_vlan_pool
• vlanpool_fixes
• vlanpool_omit_braces
• sfna_fix_delete
• validate_plugin_vlan
• more_pod_checks
• lmr
• fix-crash
• multipod-vm-delete-odev
• ss-svc-ip-fix
• node-del-ipam-fix
• del-ipam-fix
• knob_handling
• remove_travis_tags
• operator-debug-log
• add-debug-option-op
• dep-alert-fix
• serviceBdRoutingDisable
• bridge_cni
• odev-queue
• HostprotRemoteIpDel
• race_fix
• cnifix
• skip-mos-of-other-tenant
• query-optimize
• loopback-fix
• upgrade_to_k8s1.28
• fix-travis-docker-buildx
• platformconfig
• serviceBdRoutingDisable-version-fix
• nad_webhook
• shaikmas-jira-138-exclude-nodes-from-snat-redirect-policy
• ocp-4.14-flavors
• default-epg-consume-ingress-contract
• hpp-subscrib-fix
• enable_opflex_agent_reconnect
• rename_sfna
• reset-conf
• cleanup_core
• serialize-ovs-ports-sync
• serialize-ovs-ports-sync-code
• shaikmas-uts
• cleanup-ovs
• ovs-port-sync
• ha-ut
• ovs-ports-sync
• ipvlan_cni
• lmr-6.0.3
• snaiksat-patch-1
• version_fix
• upgrade-go-1.21-k8s-1.29
• webhook_image_updates
• upgrade_k8s_1.29
• cicd
• upgrade-go-1.21
• upgrade_to_k8s1.29
• apic-switchover-issue
• ignore-files-from-coverage
• fix_webhook_compilation
• allow-all-np-opt
• contract-and-epg-contract-provision-from-k8s
• vmmdombug
• subscription-wcard-fix
• disable-hpp-rendering-based-on-flag
• tenant-match
• ovs-stale-check
• revert-build-openvswitch-travis-changes
• nadvlanmap_validation
• watch-reboot
• ep-queue
• upgrade-fix
• chained_mode_skip_watch_reboot
• add-ep-timestamps
• servicebd-version-check
• upgrade-fix-ip-alloc
• veth-lock
• fix-grpc-version
• rdconfig-race
• dummy-fix
• ovs-logs
• backport-lmr-6.0.3
• cleanup-revert
• vlan_range_fix
• add-unit-tests
• ovs_cni
• ovs_cni_build_flags
• serviceBdRoutingDisable_default
• add-taint-for-not-ready-node
• droplog_cleanup
• touch_ep_after_adding_port
• write_ep_file_after_pod_addition
• fix-node-taint-issues
• nfc_fixes
• separate-queue-for-processing-ports
• crd_removal
• istio-version-update
• ovs_lldp_fixes
• istio
• istio-remove
• fixifaceMapDeletion
• add_routed_flag
• remove-aws-lib
• snat-lock-fixes
• np_allow_protocol_fix
• add-agent-flavor
• race-docker
• preexisting_tenant
• sort_snat_svc_graph_nodes
• priority-queue
• vlan_upfront
• add-uts
• program_vlan_upfront
• fix-service-ip-allocation
• skip-netpol-sync-check-on-disable-hpp-rendering
• fix-failed-to-update-service-status-error
• aaep_fix
• add-aci-cilium-changes
• remove-pkg-errors
• depalert-fix
• upstream-sriovnet
• add-uts-2
• remove-opflex-dockerfiles
• cdets-74312-dns-fix
• opflex-uts
• local-hpp
• upgrade_fix
• node_reload_fix
• topology-mode-updates
• fix-ipam-ut-coverage-report
• ubi
• add-missing
• fix-snat-ut
• opflex-startup
• multiple_sriov_ifs
• shared_aep_delete_fix
• fix-test-crd-delete-ut
• acikubectl-trace-dp
• policyopfl
• dependabot/go_modules/golang.org/x/net-0.23.0
• l3_model
• pkg-upgrade
• lmr-6.0.4
• upgrade-pkg
• polopfl
• cicd-lmr-update
• ocp_415_flv
• remove-cloud-support-with-capic
• l3_model_fixes
• remove-lib-pins
• cnf_bgp
• rename_crd
• webhook_fixes
• skip-opflexodev-del
• skip-opflexodev-del-lmr-6.0.4
• cleanup-capic-code
• restore_svi_on_reboot
• service-bd-unkMacUcastAct-proxy
• remove-gbpsstate
• remove-epg-contract-crd-support
• k8s-0.29.6
• set-service-bd-unkMacUcastAct-proxy
• set-service-bd-unkMacUcastAct-proxy-backport
• pkg-upgrade-go-1-22
• ctrl_runtime_update
• make-check
• fix_binding
• l3out_fixes
• hpp-opt-fix
• remove-epslice-option
• local-hpp-classnames-fix
• hpp-opt-fix-backport
• opflex-log
• np-logs
• info-log
• opflex-info-log-backport
• np-logs-backport
• opflex-log-backport
• preprovision_l3out
• validations_for_crs
• local-hpp-code-optimization
• single_if_fix
• typo-fix
• typo-fix-backport
• more_validation
• local-hpp-optimization
• backport_more_validation
• suboptimal_peers
• ocp416
• delete-devices-fix
• delete-devices-fix-backport
• update-netpol-egress-pods-on-ns-update
• l3cnf_static_route_fix
• mmr-6.1.1
• allow_multiple_ifs
• outofband-policy
• disable_service_vlan_preprovisioning
• disable_service_vlan_preprovisioning_backport1
• outofband-policy-backport-to-6.1.1
• disable_service_vlan_preprovisioning_backport2
• outofband-policy-backport-to-6.0.4
• anm-travis-update
• revert-OutOfBandPolicy-CR
• proactive-conf
• proactiveconf-mmr611
• oob_acikubectl
• proactiveconf-lmr604
• nad-config-name
• backport-1386
• nad-config-name-lmr
• oob_acikubectl_user_crt
• proactiveconf-changes
• oob_acikubectl_crt_key
• oob_acikubectl_crd
• oob_acikubectl_fix_find_files
• proactivepolicy_fixes
• fix_error_check
• acikubectl_trace_add_udp
• fix-filterfvRsDomAtt
• proactiveconf-changes-mmr611
• proactiveconf-changes-lmr604
• arm64
• patch-arm64
• apply_static_paths
• annotation-error-fix
• backport_lldpif_updates
• annotation-error-fix-backport1
• annotation-error-fix-backport2
• advertise_subnet
• patch-3082
• subs_lockhandling
• backport_fix_lldpq
• pod-ts-init-race
• stale-snat-files-fix
• optimize-hpp-sync
• opflex-agent-status
• fix_subs_refresh
• backport_subs_refresh
• docker-fix-openvswitch-base
• cherrypick-docker-fix-openvswitch-base
• cherrypick-6.0.4-fix-ovs-base
• cherrypick-6.0.3-fix-ovs-base
• fix-dockerfile-host
• opflex-agent-status-mmr611
• opflex-agent-status-lmr604
• mmr_611_fix-dockerfile-host
• add-ubi-latest
• lldpif_clear_cache
• backport_lldpif_clear_cache
• fix-dockerfile-hostagent
• mmr-611-host-dockerfile-fix
• pod-ts-init-race-mmr611
• pod-ts-init-race-lmr604
• stale-snat-files-fix-mmr611
• optimize-hpp-sync-mmr611
• stale-snat-files-fix-lmr604
• host-docker-fix
• multipod-fixes
• add_pyyaml
• m_pyyaml

Build # 6225

Build Type

push

travis-ci-com

Committed by akhilamohanan

Commit Message

<a href="https://github.com/noironetworks/aci-containers/commit/<a class=hub.com/noironetworks/aci-containers/commit/46ec1c47b87eed9f58e359b3b4691f203caa8aef">46ec1c47b<a href="https://github.com/noironetworks/aci-containers/commit/46ec1c47b87eed9f58e359b3b4691f203caa8aef">&quot;&gt;Fixed deadlock in hostagent

Trying to access snatPolicyCacheMutex.RLock again in same goroutine
without releasing already acquired snatPolicyCacheMutex.RLock was causing
deadlock. This goroutine accessed its first snatPolicyCacheMutex.RLock
and then another goroutine stated waiting for snatPolicyCacheMutex.Lock
and hence the first goroutine was not able to access the 2nd
snatPolicyCacheMutex.RLock which caused the deadlock

Avoided the 2nd occurance of snatPolicyCacheMutex.RLock in same
goroutine without releasing the 1st read lock.

(cherry picked from commit </a><a class="double-link" href="https://github.com/noironetworks/aci-containers/commit/<a class="double-link" href="https://github.com/noironetworks/aci-containers/commit/65e7351d01252b1f561af892bccc538cc7c3e586">65e7351d0</a>">65e7351d0</a><a href="https://github.com/noironetworks/aci-containers/commit/46ec1c47b87eed9f58e359b3b4691f203caa8aef">)

Run Details

3 of 3 new or added lines in 2 files covered. (100.0%)

11545 of 20167 relevant lines covered (57.25%)

0.64 hits per line