elParaguayo / qtile

82%

master: 83%

LAST BUILD ON BRANCH fix-textbox-widgets-padding

branch: fix-textbox-widgets-padding

CHANGE BRANCH

x

Reset

Sync Branches

• fix-textbox-widgets-padding
• 3digit-rgb
• add-cairocffi-tox
• add-default-config-option
• add-plasma
• async-functions
• battery-icon-padding
• better-error-handling
• better-finalisation
• better-logging-widget-error
• bitwise-match
• black-fixes
• blackgolybpr
• bluetooth-log-spamming
• bsp-margin-single
• centre-floating
• ci-PIthon
• ci-backend-matrix
• ci-mypy
• ci-py311
• ci-py313
• ci-pypy
• ci-rtd-version-bump
• cmd-decorator-tidy-up
• cmd-obj-kwargs
• cmd_obj_pass_kwargs
• cmd_paint_screen
• codestyle-badge
• columns-black-formatting
• columns-default-ratio
• columns-for-lefties
• command-graph-decorators
• config-allow-keycodes
• config-group-typing
• coveralls-badge
• custom_hooks
• custom_log_path
• dbus-fast-migration
• dbus-signal-handling
• debugging-pulsevolume
• delay-libcst
• delete-coveragerc
• desktop-client-message
• different-borders
• doc_fixes
• docs-better-hooks
• docs-cairo-fail
• docs-fix-homepage
• docs-fix-widget-screenshots
• docs-html-theme
• docs-installation
• docs-lazy
• docs-quick-build
• draw-full-bar
• drawer-refactor-take3
• filter-stack-for-missing-windows
• fix-coveralls
• fix-dead-widget-polling
• fix-docs-pyxdg-ref
• fix-docs-typo
• fix-fake-notification-manager
• fix-floating-bar-bottom
• fix-has_keyboard
• fix-hook-registry
• fix-hooks-doc
• fix-imapwidget
• fix-launchar-init
• fix-libffi-version-issue
• fix-loop-exception-handler-again
• fix-matrix-defaults
• fix-mirror-static-length
• fix-mirrors
• fix-mypy-errors
• fix-notify-widget-bug
• fix-openweather-test
• fix-packaging-test
• fix-pr-workflow-typo
• fix-prompt-end
• fix-reload-split-config
• fix-screen-reconfigure-mirror-bug
• fix-screensplit-match-bug
• fix-test-fd-leak
• fix-test-net
• fix-text-margin-issue
• fix-textbox-max-chars
• fix-volume-widget-theme-handling
• fix-wayland-build
• fix-wayland-builder
• fix-wayland-builder-v2
• fix_bluetooth_dbus
• fixing-packaging
• floating-bar
• floating-exceptions
• genpollcommand-strip
• graph-weirdness
• groupbox-toggle-bug
• hide-commands
• hide-crashed-widgets
• hook-docs
• hook-registries
• hook-wake-event
• how-to-layout
• inhibitor-functions
• internal-bring-to-front
• issue-2647
• issue-2975
• issue-3093
• issue-3135
• issue-3144
• issue-3148
• issue-3157
• issue-3158
• issue-3161
• issue-3165
• issue-3171
• issue-3173
• issue-3185-groupbox-fmt
• issue-3223
• issue-3224
• issue-3228
• issue-3260
• issue-3272
• issue-3353
• issue-3411-battery-not-charging
• issue-3418
• issue-3433
• issue-3445-scrolling
• issue-3461
• issue-3475-notifications
• issue-3476-launchbar
• issue-3488
• issue-3536
• issue-3656
• issue-3668
• issue-3739-mirror-stretch
• issue-3751-window-focus
• issue-3777-wallpaper
• issue-3786-timezone-update
• issue-3800-blank-window-focus
• issue-3816-bluetooth-name
• issue-3825-docs
• issue-3854-tasklist-width
• issue-3855-launchbar-icon-size
• issue-3867-notification
• issue-3869-pango-error
• issue-3873-tasklist-alignment
• issue-3952-sni-icon-updates
• issue-3964-html-docs
• issue-4003-4004-currentlayout
• issue-4024-simple-key-binder
• issue-4043-battery-icon-position
• issue-4107-pango-markup-ampersand
• issue-4125-docs-graph-links
• issue-4132-thermalsensor-foreground
• issue-4153-notify-reload-pango-error
• issue-4224-sni-no-icons
• issue-4272-currentlayouticon-margins
• issue-4288-monadthreecol-margins
• issue-4328-widgetbox-padding
• issue-4342-keyboardlayout
• issue-4355-keep-above-bring-front
• issue-4384-broken-links
• issue-4425-bar-flickering
• issue-4552-launchbar
• issue-4589-mirrored-background
• issue-4634-treetab-resolution
• issue-4651-duplicate-keys
• issue-4670-raise-active-windows
• issue-4674-text-crashing
• issue-4705-spawn-env
• issue-4915
• issue-4979-treetab-weirdness
• issue-4986-scratchpad-border
• issue-4987
• issue-4996-tasklist-no-stretch
• issue-5029-layout-changer
• issue-5122-statusnotifier-new-icons
• issue-5141-text-padding
• issue-5283
• issue-5700-keysym-from-code
• issue-5737-missing-interface
• issue-5747
• issue-5753-hook-unsubscribe
• issue-5762-ftl-ghosts
• issue-5830-treetab-layer
• issue-5831-spawn-pathlike
• issue-5843-lose-focus-between-screens
• issue-5847-expose-notify-activity
• issue-5856-systray
• issue-5886-text-widget-finalisation
• issue-5892-vertical-bar-click
• issue-5893-spawn-crash
• issue-5913-background-poll
• issue2912-window-centre
• issue4668-launchbar-clone
• issue_3637
• jagguli-cpu
• jw-wlr017
• key-docs
• keychord-desc
• latest-black-update
• launchbar-font
• launchbar-render-fix
• layout-icon-paths
• layout-screenshots
• layout-slice-window
• layout-spiral
• loop-exception-logging
• main-plus-testing
• master
• mcol-cmdobj
• mem-custom-value
• migrate-libcst
• mirror-fixes
• more-mirror-fixes
• more-tests
• more_shell_improvements
• mpris-fix-format-string
• mpris-metadata-on-reload
• mpris2-add-player-name
• mpris2-metadata-on-reload
• new-bluetooth-widget
• new-pulsevolume-widget
• notify-background
• notify-better-timeouts
• noxwayland-build-failure
• pin-pytest-cov
• plasma-docs
• plasma-fix-add-mode-status
• plugging-qtile-examples
• pseudo-transparency
• pulse-single-server-connection
• pulse-widget-creation-timing
• pyproject-extras
• pyproject-scm-version
• pytest-cov-3
• qtile-repl
• qtile-shell-cmd-args
• quick-check
• reconfig-windows-bug
• reduce_logging
• register-new-hooks
• remove-docs-test
• remove-flaky-test
• remove-heisenbugs
• remove-old-files
• remove-print
• remove-pulse-cffi-setup
• remove-redundant-calls
• repl-fix
• repl-fixes
• revert-keyboard-grab
• revert-khal-calendar-test
• revert-maximize-commit
• revert-pyproject-toml
• revert-systray-icon-ordering
• rtd-inline
• scratchpad-crash
• scratchpad-kill-bug
• screensplit
• shell_dont_split_eval_args
• simplify_cmd_spawn
• single-systray
• skip-spawn-in-group-test
• sleep-hook-docs
• sni-callbacks-on-reload
• sni-fixes
• sni-fixes-v2
• sni-fixes-v3
• sni-refactor
• sni-swallow-ayatana-errors
• sni-typo
• sni_test_failure
• spawn-in-group
• suspend-hook
• svg-image-issue
• swaync-widget
• systray-icon-order
• systray-inheritance
• systray-typo
• tasklist-calculated-width
• tasklist-desktop
• tasklist-img
• test-ci-fix
• test-openweather
• test-rtd-webhook
• test-systray
• test-tasklist
• test-vertical-bars
• test_wlan_docs_build
• threecol-icon
• tidy-notify-clear
• tidy-up-dbus-matches
• tox-4-gh-actions
• tox-dbus-next
• tych0-screens
• update-copyright-date
• update-default-config
• update-threadpooltext
• use-caplog
• user-idle-timers
• v0.23.0-beta3
• venv-build-failure
• vertical-clock
• vertical-launchbar
• vertical-tasklist
• vertical-text-no-rotate
• wallpaper-resize
• wayc-build-debugging
• wayc-drag-icon
• wayc-drag-layer-fix
• wayc-ext-session-lock
• wayc-fix-title
• wayc-fullscreen-debugging
• wayc-gitignore
• wayc-image-capture
• wayc-limit-scroll-callbacks
• wayc-move-bar-to-layer-group
• wayc-move-up-down
• wayc-no-screen-change-on-vt-switch
• wayc-no-xdg-decorations
• wayc-remove-xwayland-fullscreen-background
• wayc-rtd2
• wayc-scrolling-displacement-limit
• wayc-scrolling-rate
• wayc-skip-dgroup-test
• wayc-test-rebase
• wayc-tidy-ftl
• wayc-tidy-up-internal
• wayc-track-focused-view
• wayc-xwayland-clipboard
• wayc-xwayland-crash
• wayc-xwayland-titles
• wayc-xwyland-props
• wayland-above-below
• wayland-border-opacity
• wayland-build-option
• wayland-default-vt
• wayland-fix-prompt-crash
• wayland-ftl-urgent-window
• wayland-handle-key-repeats
• wayland-idle
• wayland-image-copy
• wayland-layer-shell-version
• wayland-logging
• wayland-output-power-management
• wayland-pager-focus
• wayland-silence-build-warning
• wayland-skip-taskbar
• wayland-touch-device-support
• wayland-transient-for
• wayland-wm-type
• wayland_remove_scroll_logging
• when-backend
• widget-screenshots
• widget_import_errors
• widgetbox-bar-border
• widgetbox-open-close
• widgetbox-start-toggled
• window-border-styling
• window-clipping
• wrap-text
• x11-drawer-clear
• x11-floating-layers
• x11-layering-floating-issue
• x11-pointerbarrier-screen-focus
• x11-test-fix
• z-layer-management

Build # 20694725909

Build Type

push

github

Committed by elParaguayo

Commit Message

Fix groupbox crash when padding is None

The GroupBox widget inherits from `base._TextBox` and, as a result, the
docs explain that setting a `padding` value of `None` will cause the
widget to calculate the padding. However, `GroupBox._configure` does not
call `base._TextBox._configure` and so the calculation is never
performed. This can result in a crash as the widget tries to calculate
positions by including the padding value, resulting in a `TypeError`.

Fixes #5752

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

16755 of 20534 relevant lines covered (81.6%)

4.44 hits per line