elParaguayo / qtile / 20694725909

82%

master: 83%

Build Type

push

github

Committed by elParaguayo

Commit Message

Fix groupbox crash when padding is None

The GroupBox widget inherits from `base._TextBox` and, as a result, the
docs explain that setting a `padding` value of `None` will cause the
widget to calculate the padding. However, `GroupBox._configure` does not
call `base._TextBox._configure` and so the calculation is never
performed. This can result in a crash as the widget tries to calculate
positions by including the padding value, resulting in a `TypeError`.

Fixes #5752

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

16755 of 20534 relevant lines covered (81.6%)

4.44 hits per line