elParaguayo / qtile / 20667767242

82%

master: 83%

Build Type

push

github

Committed by elParaguayo

Commit Message

Fix groupbox crash when padding is None

The GroupBox widget inherits from `base._TextBox` and, as a result, the
docs explain that setting a `padding` value of `None` will cause the
widget to calculate the padding. However, `GroupBox._configure` does not
call `base._TextBox._configure` and so the calculation is never
performed. This can result in a crash as the widget tries to calculate
positions by including the padding value, resulting in a `TypeError`.

Fixes #5752

Run Details

1 of 2 new or added lines in 1 file covered. (50.0%)

1 existing line in 1 file now uncovered.

16760 of 20536 relevant lines covered (81.61%)

4.45 hits per line