decentraland / realm-provider

51%

main: 51%

push

github

fix: guard /stats/parcels response.ok in hot-scenes handler (#91)

All DAO catalyst nodes now return 404 for /stats/parcels since the
per-catalyst Archipelago layer was migrated to archipelago-ea. The
handler was not checking response.ok, so parcelsResponse.parcels was
undefined. The promise resolved as fulfilled (not rejected), bypassing
Promise.allSettled, and the subsequent for...of iteration threw
TypeError: undefined is not iterable — causing the 500.

Add response.ok guards in both the per-catalyst /stats/parcels fetch
and the main-realm /parcels fetch: drain and throw on non-2xx so
Promise.allSettled handles failures gracefully and the endpoint
returns 200 with an empty list when all sources are unavailable.

Add unit tests covering the 404-from-catalyst scenario, successful
catalyst data, non-2xx from main realm, and successful main realm data.

Closes https://github.com/decentraland/realm-provider/issues/90

56 of 95 branches covered (58.95%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

166 of 340 relevant lines covered (48.82%)

16.24 hits per line