decentraland / lamb2
83%
main: 81%

LAST BUILD BRANCH: feat/lambdas-migration-endpoints
DEFAULT BRANCH: main
Repo Added
Files 82
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH feat/lambdas-migration-endpoints
branch: SELECT
CHANGE BRANCH
x

coverage: 82.91% (+1.7%) from 81.202%
25188962240

Pull #462

github

LautaroPetaccio 
test: align ported-endpoint specs with the dcl-testing skill

reshapes the unit and integration specs added in this pr to follow
the team's testing conventions:

- describe blocks use 'when' for top-level contexts and 'and' for
  nested variants ('when ?includeDefinitions is set' -> 'and the
  definitions fetcher resolves a definition for the owned urn').
- it() descriptions name a single specific outcome instead of generic
  'should throw InvalidRequestError' / 'responds 400'. multiple
  expects are kept only when they describe a single behavior.
- mocks, request objects, response bodies, and fixtures move out of
  it() bodies into the enclosing describe's beforeEach. mutable state
  is `let`-declared at describe scope and assigned per-test.
- mocks are scoped to the describe context that uses them. shared
  setup (graph spies, content client mock) stays in the suite-level
  beforeEach because it applies to every variant.
- afterEach calls jest.resetAllMocks() in every spec to keep tests
  isolated.

split compound it()s into per-assertion cases where the original was
testing several behaviors at once (e.g. 'returns 200 with body X and
calls fetcher Y' is now two its). full suite is 557 passing (was 511);
only the pre-existing ownership.spec.ts failure remains.
Pull Request #462: feat: implement legacy lambdas endpoints in lamb2

715 of 958 branches covered (74.63%)

Branch coverage included in aggregate %.

205 of 208 new or added lines in 12 files covered. (98.56%)

2026 of 2348 relevant lines covered (86.29%)

47.56 hits per line

Relevant lines Covered
2348 RELEVANT LINES 2026 COVERED LINES
47.56 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25188962240 feat/lambdas-migration-endpoints test: align ported-endpoint specs with the dcl-testing skill reshapes the unit and integration specs added in this pr to follow the team's testing conventions: - describe blocks use 'when' for top-level contexts and 'and' for nested variants (... Pull #462 LautaroPetaccio github
82.91
25186670919 feat/lambdas-migration-endpoints docs: anchor legacy wire contracts on the ported endpoints each handler that came from the deprecated lambdas service now carries a short header that names the legacy source path (catalyst/lambdas/...) and pins the request/response wire contract.... Pull #462 LautaroPetaccio github
82.91
25174631258 feat/lambdas-migration-endpoints fix: preserve legacy /profile/:id stub-on-missing behavior discovered while running lamb2 locally and diffing responses against production via tooling/compare-lambdas-endpoints.sh: - production /lambdas/profile/<addr> -> 200 { avatars: [], time... Pull #462 LautaroPetaccio github
82.91
25133709400 feat/lambdas-migration-endpoints test: cover the remaining filter combinations end-to-end the existing integration suite only exercised textsearch on the catalogs and the no-?includedefinitions / non-third-party-error branches on the by-owner endpoints. fills the gaps end-to-end... Pull #462 LautaroPetaccio github
82.88
25123804554 feat/lambdas-migration-endpoints refactor: validate /crypto/validate-signature body via @dcl/schema-validator-component drops the in-handler body parsing and shape checks in favor of the @dcl/schema-validator-component middleware, which is what the wkc ecosystem standardizes on ... Pull #462 LautaroPetaccio github
82.85
25123307219 feat/lambdas-migration-endpoints refactor: use @dcl/schemas AuthChain validator in validate-signature drops the hand-rolled isAuthLink/array.isarray checks in favor of the ajv validator already shipped in @dcl/schemas (a direct dep, also re-exported by @dcl/crypto so the runtime... Pull #462 LautaroPetaccio github
82.95
25088187723 feat/lambdas-migration-endpoints Merge branch 'main' into feat/lambdas-migration-endpoints Pull #462 web-flow github
83.01
25075904312 refs/tags/4.11.1 fix: use internal content url for server fetches (#463) push web-flow github
81.2
25073724316 main fix: use internal content url for server fetches (#463) push web-flow github
81.2
25073157918 use-internal-content-url-for-fetches fix: use internal content url for server fetches Pull #463 LautaroPetaccio github
81.2
See All Builds (289)