decentraland / comms-gatekeeper / 28047204770

85%

push

github

fix: cancel undrained undici response bodies to prevent socket/memory leaks (#272)

Since the move to native fetch (undici, via @dcl/traced-fetch-component), a
Response whose body is never read keeps its pooled socket checked out and its
bytes buffered until GC — under load this leaks connections and memory. Several
call sites obtained a Response and discarded it (returned/threw) without reading
or cancelling the body; they now release it with response.body?.cancel() on the
discard paths:

- adapters/fetch.ts: cache fetchMethod cancels on the !ok throw (backs every
  cached read: denylist, names, places, worlds, lands)
- adapters/notifications.ts: fire-and-forget POST never reads the body; cancel it
- adapters/worlds.ts: fetchWorldSceneByPointer, getWorldParcelPermissions,
  getWorldParcelPermissionAddresses, fetchWorldSceneId
- adapters/places.ts: getWorldByName
- adapters/social.ts: getUserPrivacySettings
- adapters/lands/component.ts: fetchAuthorizationsFromUpstream

Sites that already consume the body via response.json() on every path are
unaffected. Adds cancel-assertion tests for the cache wrapper, social and worlds.

1087 of 1401 branches covered (77.59%)

Branch coverage included in aggregate %.

8 of 10 new or added lines in 6 files covered. (80.0%)

2995 of 3387 relevant lines covered (88.43%)

74.78 hits per line