decentraland / comms-gatekeeper / 28041467667

85%

push

github

fix: suppress comms events for preview realms regardless of ALLOW_LOCAL_PREVIEW (#271)

The participant joined/left webhook handlers skipped publishing
UserJoinedRoom/UserLeftRoom events for local preview realms via
livekit.isLocalPreview(). That predicate is gated behind the
ALLOW_LOCAL_PREVIEW config flag, which is intentionally disabled in
production (it bypasses auth, scene-ban enforcement and authorization
for preview realms). As a result the suppression never ran in
production and preview sessions — which connect to production comms —
still produced events.

Split the overloaded predicate in the livekit adapter:

- isPreviewRealmName(realmName): name-only detection, independent of the
  config flag. Grants no privileges, so it is safe to evaluate in
  production. Used by the join/left handlers to suppress events.
- isLocalPreview(realmName): now layers the ALLOW_LOCAL_PREVIEW gate on
  top of isPreviewRealmName and remains the predicate for the
  privilege-granting code paths, which must stay gated in production.

The existing handler unit tests stayed green only because the livekit
mock modeled isLocalPreview as a name-only check, masking the gate.
Added regression tests that reproduce production (gate off,
isPreviewRealmName true) and assert events are still suppressed, plus
adapter coverage for isPreviewRealmName.

1087 of 1401 branches covered (77.59%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 3 files covered. (100.0%)

2987 of 3378 relevant lines covered (88.43%)

74.95 hits per line